{ "id": "149441", "key": "AC-199", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "12217", "key": "AC", "name": "Appcelerator - INBOX", "projectCategory": { "id": "10000", "description": "", "name": "Customer Service" } }, "resolution": { "id": "8", "description": "", "name": "Needs more info" }, "resolutiondate": "2015-12-22T09:13:39.000+0000", "created": "2015-07-05T09:42:32.000+0000", "labels": [ "android" ], "versions": [], "issuelinks": [], "assignee": { "name": "ingo", "key": "ingo", "displayName": "Ingo Muschenetz", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2015-12-22T09:13:39.000+0000", "status": { "description": "A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.", "name": "Resolved", "id": "5", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "14548", "name": "Titanium SDK & CLI", "description": "Please enter tickets related to the MobileSDK here." } ], "description": "Let one of your top Java developers take a look at the way _listeners_ is being managed. Mainly the use of _toRemove_ list in _handleFireDownloadMessage_.\r\n\r\nNote that _listenerList_ itself is not removed from _listeners_ when it's done.\r\n\r\nAlso you should consider if the use of _SoftReference_ is wise, specially since you remove the listener after the callback is invoked.", "attachment": [], "flagged": false, "summary": "TiDownloadManager (Android) needs serious code review", "creator": { "name": "buddyguards", "key": "buddyguards", "displayName": "grebulon", "active": true, "timeZone": "Asia/Jerusalem" }, "subtasks": [], "reporter": { "name": "buddyguards", "key": "buddyguards", "displayName": "grebulon", "active": true, "timeZone": "Asia/Jerusalem" }, "environment": "Android\r\nTitanium 4.0.1", "comment": { "comments": [ { "id": "370326", "author": { "name": "ingo", "key": "ingo", "displayName": "Ingo Muschenetz", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~buddyguards] thank you for the feedback and insight. Are you interested in contributing a PR with the updates you feel are important, or would you like to review a PR once it is complete?", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-11-16T07:45:43.000+0000", "updated": "2015-11-16T07:49:01.000+0000" }, { "id": "370343", "author": { "name": "buddyguards", "key": "buddyguards", "displayName": "grebulon", "active": true, "timeZone": "Asia/Jerusalem" }, "body": "I just replaced the whole class with UniversalImageLoader :-) Wrote a thin interface that matches TiDownloadManager. It boosted the download performance considerably.\r\nBut I will gladly review the code when it's submitted.", "updateAuthor": { "name": "buddyguards", "key": "buddyguards", "displayName": "grebulon", "active": true, "timeZone": "Asia/Jerusalem" }, "created": "2015-11-16T13:53:36.000+0000", "updated": "2015-11-16T13:53:36.000+0000" }, { "id": "372021", "author": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "body": "[~buddyguards] Is it possible for you to provide a sample of the code that you wrote?", "updateAuthor": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "created": "2015-12-03T07:47:10.000+0000", "updated": "2015-12-03T07:47:10.000+0000" } ], "maxResults": 6, "total": 6, "startAt": 0 } } }