[AC-6721] Improve documentation: VideoPlayer, TabGroup
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | n/a |
| Status | Open |
| Resolution | Unresolved |
| Affected Version/s | n/a |
| Fix Version/s | n/a |
| Components | n/a |
| Labels | n/a |
| Reporter | Michael Gangolf |
| Assignee | Abir Mukherjee |
| Created | 2021-10-04T12:28:15.000+0000 |
| Updated | 2021-10-04T12:28:34.000+0000 |
Description
Found two parts in the documentation that needs to be improved:
https://github.com/appcelerator/titanium_mobile/pull/13071
TabGroup: shiftMode on Anrdoid
Since this old PR we have 3 shiftMode types on Android:
7b3c292#diff-88df67787e4e1b86cf521062eeb89d4e91082c17f403cc6623f36388e0dc7d7cR172-R180
but we only list it as a boolean. I've changed it to Number and added a description of value 2.
VideoPlayer: volume property on Android
Volume can be set in an Android video player for a long time but it is not marked in the docs.
https://github.com/appcelerator/titanium_mobile/blame/fe3deddcea07ecb3555673cf2dba8d676fd79611/android/modules/media/src/java/ti/modules/titanium/media/TiUIVideoView.java#L131-L134
PR https://github.com/appcelerator/titanium_mobile/pull/13071