{
"id": "159139",
"key": "ALOY-1479",
"fields": {
"issuetype": {
"id": "1",
"description": "A problem which impairs or prevents the functions of the product.",
"name": "Bug",
"subtask": false
},
"project": {
"id": "11113",
"key": "ALOY",
"name": "Alloy",
"projectCategory": {
"id": "10400",
"description": "Tools for developing applications",
"name": "Tooling"
}
},
"fixVersions": [
{
"id": "18001",
"name": "Release 5.2.2",
"archived": false,
"released": true,
"releaseDate": "2016-06-28"
},
{
"id": "18003",
"name": "alloy 1.8.4",
"archived": false,
"released": true,
"releaseDate": "2016-03-29"
},
{
"id": "18005",
"name": "alloy 1.8.5",
"archived": false,
"released": true,
"releaseDate": "2016-03-30"
}
],
"resolution": {
"id": "1",
"description": "A fix for this issue is checked into the tree and tested.",
"name": "Fixed"
},
"resolutiondate": "2016-03-30T21:20:19.000+0000",
"created": "2016-03-30T13:41:20.000+0000",
"priority": {
"name": "Critical",
"id": "1"
},
"labels": [],
"versions": [
{
"id": "17997",
"name": "alloy 1.8.3",
"archived": false,
"released": true,
"releaseDate": "2016-03-28"
},
{
"id": "18003",
"name": "alloy 1.8.4",
"archived": false,
"released": true,
"releaseDate": "2016-03-29"
}
],
"issuelinks": [],
"assignee": {
"name": "fokkezb",
"key": "fokke",
"displayName": "Fokke Zandbergen",
"active": true,
"timeZone": "Europe/Amsterdam"
},
"updated": "2016-03-31T23:27:44.000+0000",
"status": {
"description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.",
"name": "Closed",
"id": "6",
"statusCategory": {
"id": 3,
"key": "done",
"colorName": "green",
"name": "Done"
}
},
"components": [
{
"id": "13605",
"name": "Models"
}
],
"description": "Data binding of local model instances throws an exception in Alloy 1.8.3 and 1.8.4 because of [this line change|https://github.com/appcelerator/alloy/pull/769/files#diff-a59a2178e486f81366775c39e5393695L521] to resolve ALOY-1369.\r\n\r\n*XML*\r\n\r\n{code:xml}\r\n\t\t\r\n\t\t\r\n{code}\r\n\r\n*compiled*\r\n\r\n{code:js}\r\n $.__alloyId4.text = _.template(\"{$.modelinstance.foo}\", {\r\n modelinstance: transformed\r\n }, {\r\n interpolate: /\\{([\\s\\S]+?)\\}/g\r\n });\r\n $.__alloyId5.text = _.template(\"{$.modelinstance.foo} {$.modelinstance.bar}\", {\r\n modelinstance: transformed\r\n }, {\r\n interpolate: /\\{([\\s\\S]+?)\\}/g\r\n });\r\n{code}",
"attachment": [],
"flagged": false,
"summary": "Regression: Model instance data binding no longer works",
"creator": {
"name": "fokkezb",
"key": "fokke",
"displayName": "Fokke Zandbergen",
"active": true,
"timeZone": "Europe/Amsterdam"
},
"subtasks": [],
"reporter": {
"name": "fokkezb",
"key": "fokke",
"displayName": "Fokke Zandbergen",
"active": true,
"timeZone": "Europe/Amsterdam"
},
"environment": null,
"closedSprints": [
{
"id": 615,
"state": "closed",
"name": "2016 Sprint 07 Tooling",
"startDate": "2016-03-26T00:40:48.770Z",
"endDate": "2016-04-09T00:40:00.000Z",
"completeDate": "2016-04-11T04:48:57.781Z",
"originBoardId": 121
}
],
"comment": {
"comments": [
{
"id": "381038",
"author": {
"name": "fokkezb",
"key": "fokke",
"displayName": "Fokke Zandbergen",
"active": true,
"timeZone": "Europe/Amsterdam"
},
"body": "/cc [~cng] [~emerriman] [~fmiao]",
"updateAuthor": {
"name": "fokkezb",
"key": "fokke",
"displayName": "Fokke Zandbergen",
"active": true,
"timeZone": "Europe/Amsterdam"
},
"created": "2016-03-30T13:41:40.000+0000",
"updated": "2016-03-30T13:41:40.000+0000"
},
{
"id": "381041",
"author": {
"name": "fokkezb",
"key": "fokke",
"displayName": "Fokke Zandbergen",
"active": true,
"timeZone": "Europe/Amsterdam"
},
"body": "I'm including a test app that covers all of the following cases:\r\n\r\n# Simple global model data binding\r\n# Complex global model data binding\r\n# Complex global model data binding with undefined model attribute\r\n# Simple local model instance data binding\r\n# Complex local model instance data binding\r\n# Complex local model instance data binding with undefined model attribute\r\n# Simple global collection data binding\r\n# Complex global collection data binding\r\n# Complex global collection data binding with undefined model attribute\r\n# Simple local collection instance data binding\r\n# Complex local collection instance data binding\r\n# Complex local collection instance data binding with undefined model attribute\r\n# Simple global collection data binding in required view\r\n# Complex global collection data binding in required view\r\n# Complex global collection data binding in required view with undefined model attribute\r\n# Simple local collection instance data binding in required view\r\n# Complex local collection instance data binding in required view\r\n# Complex local collection instance data binding in required view with undefined model attribute\r\n\r\nThe following cases are already covered by the test app for ALOY-1474:\r\n\r\n# Simple global model data binding\r\n# Complex global model data binding\r\n# Simple global model data binding with model transform method\r\n# Complex global model data binding with model transform method\r\n# Simple global collection data binding\r\n# Complex global collection data binding\r\n# Complex global collection data binding with controller transform method\r\n# Simple global collection data binding with model transform method\r\n# Complex global collection data binding with model transform method\r\n# Complex global collection data binding with model transform method, overridden by controller transform method\r\n\r\nThat should do it.",
"updateAuthor": {
"name": "fokkezb",
"key": "fokke",
"displayName": "Fokke Zandbergen",
"active": true,
"timeZone": "Europe/Amsterdam"
},
"created": "2016-03-30T14:13:18.000+0000",
"updated": "2016-03-30T14:13:49.000+0000"
},
{
"id": "381044",
"author": {
"name": "fokkezb",
"key": "fokke",
"displayName": "Fokke Zandbergen",
"active": true,
"timeZone": "Europe/Amsterdam"
},
"body": "PR with test instructions: https://github.com/appcelerator/alloy/pull/779\r\n\r\nDid you know we had 0 tests for data binding local instances of models or collections?",
"updateAuthor": {
"name": "fokkezb",
"key": "fokke",
"displayName": "Fokke Zandbergen",
"active": true,
"timeZone": "Europe/Amsterdam"
},
"created": "2016-03-30T14:34:42.000+0000",
"updated": "2016-03-30T14:34:42.000+0000"
},
{
"id": "381075",
"author": {
"name": "fmiao",
"key": "fmiao",
"displayName": "Feon Sua Xin Miao",
"active": true,
"timeZone": "America/Vancouver"
},
"body": "We do have tests for local instance of collection, i.e\r\nhttps://github.com/appcelerator/alloy/blob/master/test/apps/testing/ALOY-874/\r\n\r\nOverall, the list you have is bulletproof, and the fix looks good!\r\n\r\n",
"updateAuthor": {
"name": "fmiao",
"key": "fmiao",
"displayName": "Feon Sua Xin Miao",
"active": true,
"timeZone": "America/Vancouver"
},
"created": "2016-03-30T19:26:25.000+0000",
"updated": "2016-03-30T19:26:41.000+0000"
},
{
"id": "381084",
"author": {
"name": "fokkezb",
"key": "fokke",
"displayName": "Fokke Zandbergen",
"active": true,
"timeZone": "Europe/Amsterdam"
},
"body": "That's for a collection. Do we also have one for a instance of a model?",
"updateAuthor": {
"name": "fokkezb",
"key": "fokke",
"displayName": "Fokke Zandbergen",
"active": true,
"timeZone": "Europe/Amsterdam"
},
"created": "2016-03-30T19:44:49.000+0000",
"updated": "2016-03-30T19:44:49.000+0000"
},
{
"id": "381086",
"author": {
"name": "fmiao",
"key": "fmiao",
"displayName": "Feon Sua Xin Miao",
"active": true,
"timeZone": "America/Vancouver"
},
"body": "We now do! You just added it! :)",
"updateAuthor": {
"name": "fmiao",
"key": "fmiao",
"displayName": "Feon Sua Xin Miao",
"active": true,
"timeZone": "America/Vancouver"
},
"created": "2016-03-30T19:49:21.000+0000",
"updated": "2016-03-30T19:49:21.000+0000"
},
{
"id": "381093",
"author": {
"name": "fmiao",
"key": "fmiao",
"displayName": "Feon Sua Xin Miao",
"active": true,
"timeZone": "America/Vancouver"
},
"body": "PR merged. \r\nAlloy@1.8.5",
"updateAuthor": {
"name": "fmiao",
"key": "fmiao",
"displayName": "Feon Sua Xin Miao",
"active": true,
"timeZone": "America/Vancouver"
},
"created": "2016-03-30T21:20:19.000+0000",
"updated": "2016-03-30T21:20:19.000+0000"
},
{
"id": "381249",
"author": {
"name": "ewieber",
"key": "ewieber",
"displayName": "Eric Wieber",
"active": false,
"timeZone": "America/Los_Angeles"
},
"body": "Verified fixed, using:\r\n\r\nMacOS 10.11.4 (15E65)\r\nStudio 4.5.0.201602170821\r\nTi SDK 5.2.2.v20160328141205\r\nAppc NPM 4.2.5-1\r\nAppc CLI 5.2.2-3\r\nAlloy 1.8.5\r\nXcode 7.3 (7D175)\r\n\r\nData binding for models is working as expected. Tested using the test app provided by Fokke as well as other created test apps. No exception is encountered and model data is correctly shown.",
"updateAuthor": {
"name": "ewieber",
"key": "ewieber",
"displayName": "Eric Wieber",
"active": false,
"timeZone": "America/Los_Angeles"
},
"created": "2016-03-31T23:27:44.000+0000",
"updated": "2016-03-31T23:27:44.000+0000"
}
],
"maxResults": 9,
"total": 9,
"startAt": 0
}
}
}