{ "id": "165488", "key": "ALOY-1537", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "11113", "key": "ALOY", "name": "Alloy", "projectCategory": { "id": "10400", "description": "Tools for developing applications", "name": "Tooling" } }, "fixVersions": [ { "id": "19089", "name": "alloy 1.9.7", "archived": false, "released": true, "releaseDate": "2017-02-15" }, { "id": "19280", "name": "Release 6.2.0", "archived": false, "released": true } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2017-02-22T04:39:29.000+0000", "created": "2017-01-27T06:48:52.000+0000", "priority": { "name": "High", "id": "2" }, "labels": [], "versions": [], "issuelinks": [ { "id": "54043", "type": { "id": "10002", "name": "Duplicate", "inward": "is duplicated by", "outward": "duplicates" }, "inwardIssue": { "id": "165493", "key": "ALOY-1539", "fields": { "summary": "Correct NSP/Retire.js errors in alloy", "status": { "description": "A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.", "name": "Resolved", "id": "5", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Critical", "id": "1" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } } ], "assignee": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "updated": "2017-04-03T19:36:27.000+0000", "status": { "description": "A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.", "name": "Resolved", "id": "5", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "13604", "name": "Tooling", "description": "Items related to Alloy tooling and workflow" } ], "description": "Ran {{nsp check}}, two alloy dependencies, {{uglify-js@2.4.15}} and {{moment@2.10.6}}, are returning {{Regular Expression Denial of Service}}. \r\n\r\nThis ticket is to track the progress of updating uglify-js from 2.4.15 to *2.6.1* and moment.js from 2.10.6 to *2.17.1*.\r\n\r\nNote: \r\nECMAScript 5.1 doesn't permit newline characters in string literals. It requires {{\\n}}. According to [903|https://github.com/mishoo/UglifyJS2/pull/903] Uglify also doesn't like it in versions 2.6.2 and after, thus failed some of the test apps. For now, updating to uglify-js@2.6.1 should correct nsp errors. We need to look into alloy compiler if we need a major uglify upgrade. ", "attachment": [], "flagged": false, "summary": "Update uglify-js and moment.js", "creator": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "subtasks": [], "reporter": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "environment": null, "closedSprints": [ { "id": 799, "state": "closed", "name": "2017 Sprint 02 Tooling", "startDate": "2017-01-15T00:01:57.583Z", "endDate": "2017-01-29T00:01:00.000Z", "completeDate": "2017-01-30T21:11:44.577Z", "originBoardId": 199 } ], "comment": { "comments": [ { "id": "405471", "author": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "body": "PR: https://github.com/appcelerator/alloy/pull/812", "updateAuthor": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "created": "2017-01-27T06:50:51.000+0000", "updated": "2017-01-27T06:50:51.000+0000" }, { "id": "407914", "author": { "name": "brentonhouse", "key": "brentonhouse", "displayName": "Brenton House", "active": true, "timeZone": "America/Chicago" }, "body": "Did the moment.js that is used at runtime get updated as well? I know there is a bug in the shipped version that has hit a lot of devs.", "updateAuthor": { "name": "brentonhouse", "key": "brentonhouse", "displayName": "Brenton House", "active": true, "timeZone": "America/Chicago" }, "created": "2017-02-23T21:59:37.000+0000", "updated": "2017-02-23T21:59:37.000+0000" }, { "id": "408014", "author": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "body": "[~brentonhouse], which version of Alloy contains the bug you mentioned? Is there a ticket for the bug?", "updateAuthor": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "created": "2017-02-26T13:16:50.000+0000", "updated": "2017-02-27T02:07:34.000+0000" }, { "id": "408016", "author": { "name": "brentonhouse", "key": "brentonhouse", "displayName": "Brenton House", "active": true, "timeZone": "America/Chicago" }, "body": "It's a bug in the old version of momentjs. I will look up the bug number. ", "updateAuthor": { "name": "brentonhouse", "key": "brentonhouse", "displayName": "Brenton House", "active": true, "timeZone": "America/Chicago" }, "created": "2017-02-27T02:12:49.000+0000", "updated": "2017-02-27T02:12:49.000+0000" }, { "id": "408018", "author": { "name": "brentonhouse", "key": "brentonhouse", "displayName": "Brenton House", "active": true, "timeZone": "America/Chicago" }, "body": "https://github.com/moment/moment/issues/2704", "updateAuthor": { "name": "brentonhouse", "key": "brentonhouse", "displayName": "Brenton House", "active": true, "timeZone": "America/Chicago" }, "created": "2017-02-27T02:18:49.000+0000", "updated": "2017-02-27T02:18:49.000+0000" }, { "id": "408086", "author": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "body": "[~brentonhouse], momentjs fix went into to version [2.14.0|https://github.com/moment/moment/pull/3177]. Alloy momentjs builtin is at 2.16.0.", "updateAuthor": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "created": "2017-02-28T00:05:41.000+0000", "updated": "2017-02-28T00:07:08.000+0000" }, { "id": "408119", "author": { "name": "brentonhouse", "key": "brentonhouse", "displayName": "Brenton House", "active": true, "timeZone": "America/Chicago" }, "body": "Thanks [~fmiao]! I wasn't paying close enough attention! We were probably dealing with it before that version of Alloy got bundled with the Appcelerator SDK.", "updateAuthor": { "name": "brentonhouse", "key": "brentonhouse", "displayName": "Brenton House", "active": true, "timeZone": "America/Chicago" }, "created": "2017-02-28T13:29:14.000+0000", "updated": "2017-02-28T13:29:14.000+0000" }, { "id": "408120", "author": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "body": "[~brentonhouse], no worries, really appreciate it! :)", "updateAuthor": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "created": "2017-02-28T13:43:04.000+0000", "updated": "2017-02-28T13:43:04.000+0000" } ], "maxResults": 9, "total": 9, "startAt": 0 } } }