[DAEMON-118] system-info: npm is always null on Windows
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | High |
Status | Resolved |
Resolution | Fixed |
Resolution Date | 2017-11-06T20:03:35.000+0000 |
Affected Version/s | Appc Daemon 1.0.0 |
Fix Version/s | Appc Daemon 1.0.0 |
Components | appcd-plugin-system-info |
Labels | n/a |
Reporter | Ewan Harris |
Assignee | Ewan Harris |
Created | 2017-11-06T15:59:33.000+0000 |
Updated | 2017-11-06T20:03:35.000+0000 |
Description
Description
appcd exec /system-info/latest/info
always returns npm info as null on Windows (works fine on OSX), logs show the below, it's in the default place for me so we should be able to find it, might be that our lookup is wrong
2017-11-06T15:56:57.025Z appcd:plugin:host:27960 > system-info@0.1.0 Unable to find where npm is installed
Default node install path is
%ProgramFiles%\\nodejs
not%ProgramFiles%\\Node.js
. However I propose that we switch this to query the registry on Windows for the install path as the installer allows for the path to be changed. Would probably need to queryHKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Node.js
andHKEY_LOCAL_MACHINE\SOFTWARE\\Node.js
for the InstallPath valuePart of https://github.com/appcelerator/appc-daemon/pull/111