[DAEMON-161] Windows: Visual Studio path is incorrect in the system-info

GitHub Issue	n/a
Type	Bug
Priority	None
Status	Resolved
Resolution	Invalid
Resolution Date	2017-11-22T18:00:41.000+0000
Affected Version/s	n/a
Fix Version/s	Appc Daemon 1.0.0
Components	appcd-plugin-windows
Labels	n/a
Reporter	Kondal Kolipaka
Assignee	Chris Barber
Created	2017-11-17T10:23:59.000+0000
Updated	2017-11-22T18:00:41.000+0000

Description

Visual studio path is incorrect in the windows system-info path *Actual:* C: /ProgramFiles(x86)/MicrosoftVisualStudio14.0/ *Expected:* C:\Program Files (x86)\Microsoft Visual Studio 14.0 Same goes for the Windows Phone SDK path *Actual:* C: \ProgramFiles(x86)\MicrosoftSDKs\WindowsPhone\v8.1\ *Expected:* C:\Program Files (x86)\Microsoft SDKs\Windows Phone\v8.1

Attachments

File	Date	Size
VS_PATH.png	2017-11-18T12:44:11.000+0000	350190
vs_paths.png	2017-11-22T17:38:26.000+0000	979971
win_system_info.txt	2017-11-17T10:23:19.000+0000	9629

Comments

Ewan Harris 2017-11-17

[~kkolipaka] Is this through appcd exec or when querying through the websocket in Studio? The windows plugin is running the same windowslib as ti info, does that report the same?

Ewan Harris 2017-11-17

Here's my visualstudio info for reference

   λ appcd exec /system-info/latest/info/windows/visualstudio                                              
   {                                                                                                       
     "Visual Studio Community 2017": {                                                                     
       "version": "Visual Studio Community 2017",                                                          
       "supported": "true",                                                                                
       "msbuildVersion": "15.3.26730.3",                                                                   
       "path": "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community",                        
       "wpsdk": null,                                                                                      
       "registryKey": null,                                                                                
       "clrVersion": null,                                                                                 
       "selected": true,                                                                                   
       "vsDevCmd": "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\Common7\\Tools\\VsDe
   vCmd.bat",                                                                                              
       "vcvarsall": "C:\\PROGRA~2\\MICROS~1\\2017\\COMMUN~1\\VC\\AUXILI~1\\Build\\VCVARS~3.BAT"            
     },                                                                                                    
     "14.0": {                                                                                             
       "version": "14.0",                                                                                  
       "registryKey": "HKEY_CURRENT_USER\\Software\\Microsoft\\VisualStudio\\14.0_Config",                 
       "supported": true,                                                                                  
       "vcvarsall": "C:\\PROGRA~2\\MICROS~1.0\\VC\\VCVARS~1.BAT",                                          
       "msbuildVersion": "14.0.25420.1",                                                                   
       "wpsdk": null,                                                                                      
       "selected": false,                                                                                  
       "path": "C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\",                                  
       "clrVersion": "v4.0.30319",                                                                         
       "vsDevCmd": "C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\Common7\\Tools\\VsDevCmd.bat"   
     }                                                                                                     
   }

Kondal Kolipaka 2017-11-17

I was using appcd exec. Look for windows->selectedVisualStudio->path Ah, okay. It's the same problem in the ti info as well.
Ewan Harris 2017-11-17
Kondal Kolipaka 2017-11-18

Haven't checked with the latest daemon in the Windows machine, but I was talking about the below path. !VS_PATH.png|thumbnail!
Ewan Harris 2017-11-20

[~kkolipaka] If possible could you run the below on the machine reg query HKEY_CURRENT_USER\Software\Microsoft\VisualStudio\14.0_Config /v *, windowslib populates the information based off what that command reports

Kondal Kolipaka 2017-11-20

   C:\Users\admin>reg query HKEY_CURRENT_USER\software\Microsoft\VisualStudio\14.0_Config /v *
   
   HKEY_CURRENT_USER\software\Microsoft\VisualStudio\14.0_Config
       InstallDir    REG_SZ    C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\
       ApplicationID    REG_SZ    VisualStudio
       ThisVersionDTECLSID    REG_SZ    {A2FA2136-EB44-4D10-A1D3-6FE1D63A7C05}
       ThisVersionSolutionCLSID    REG_SZ    {31F45B04-7198-45ED-A13F-F224A4A1686A}
       SecurityAppID    REG_SZ    {67E88D46-FF81-4E57-8C5E-F270A4F9EA1A}
       StartMenuFolder    REG_SZ    C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Visual Studio 2015\
       ShellFolder    REG_SZ    C:\Program Files (x86)\Microsoft Visual Studio 14.0\
       RequiredNDPVersion    REG_SZ    4.6
       RestoreAppPath    REG_DWORD    0x1
       (Default)    REG_SZ
       Source Directories    REG_SZ    C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\cvt\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\msclr\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\sys\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\sys\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\thr\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\crt\src\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\crt\src\amd64\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\crt\src\arm\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\crt\src\concrt\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\crt\src\i386\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\crt\src\linkopts\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\crt\src\stl\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\crt\src\vccorlib\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\crt\src\vcruntime\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\atlmfc\src\mfc\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\atlmfc\src\atl\;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\atlmfc\include\
       ConfigurationChanged    REG_QWORD    0x1d31bd0a7a1e970
       SetupCommandLine    REG_SZ    /setup
       SplashHash    REG_BINARY    01000000D08C9DDF0115D1118C7A00C04FC297EB01000000AD32B1406337C8429E4979C644D4D02304000000020000000000106600000001000020000000623C8F21F66AC87A9FB49479D780B9B84DEC4703EBCD57D68CFE093A83E8030D000000000E800000000200002000000019019CF16737258A29E6A4398941B468D20F862BCD9A4C6C1C8A600354ED61BAF00000006CC0AFD6EFF286285824F6D8D0DF26A93BAE02E70901B366D281A829D8BA93613A7166E26AA12EBA47093D21BB71DCC01A261785C864DB00698297B1DD3D92013102AE80D439FA09676261969A3F8B9EEDC12CF4E5390647EA7C268934DDDF6AF4E669B3803F675069FABFDC1E239AE37451FD94C740CF1D9B4D59CAF739AA1B7830C9A57988572EA1972CAD719F1D950CEAEA8E5DBCEF03D74B21172E72D28B4655ED4C1921EA4DAD0E1744CCA7384CAD35A0BD5A6EF34A1FB8B820114CBC387299DFE3164E73D73449F6F9171A491AA2E2C2AC0B6EA578CD9B7B882F461760AF33D2B759B7F943E8F755F6D5FF864740000000C00398CD8170CF9E9EDA4EA01EB9868D01713414CE1321F1BC5E47881A5DF897ACBC95295EF01F70407DEE9124283F8CD6D97C8A920EE268D2A81AC5D11D7178090400006000000060000000
       CLR Version    REG_SZ    v4.0.30319
       MsEnvLocation    REG_SZ    C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\msenv.dll
       VSIXInstallerLocation    REG_SZ    C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\VSIXInstaller.exe
   
   End of search: 17 match(es) found.

Ewan Harris 2017-11-22

I tried to reproduce this but was unable to. Are the logs/data from DAEMON-163 and DAEMON-162 from different machines? They both have the user as Admin, but one has the bad logs the other doesn't. Windowslib calls the query I pasted above and then parses the value out of the response, that response looks fine, I think to debug this we'd need access to the machine
Kondal Kolipaka 2017-11-22

[~eharris] Both are captured from the same windows machine at the same time almost. [~ssekhri] verified just now with the latest daemon on 7.0.0-master.40. We still see the issue. Please find the below screenshot. !VS_PATH.png|thumbnail! *Actual Paths from Ti info:* Microsoft (R) Visual Studio 14.0 (selected) Path = C:\Program Files (x86)\Microsoft Visual Studio 14.0\ CLR Version = v4.0.30319 MSBuild Version = v14.0.25420.1 Windows Phone SDKs = not installed Microsoft (R) Windows Phone SDK 10.0 Path = C:\Program Files (x86)\Windows Kits\10\ 8.1 (selected) Path = C:\Program Files (x86)\Microsoft SDKs\Windows Phone\v8.1\
Kondal Kolipaka 2017-11-22

If you're curious why and how we use that in the studio. https://github.com/appcelerator/titanium_studio/blob/ff4d05c84dc2da37f806be3ddf7ed313a21d7014/plugins/com.appcelerator.titanium.windows.core/src/com/appcelerator/titanium/windows/core/DaemonWindowsSDKLocator.java#L293 Check the line numbers - 282 and 293
Ewan Harris 2017-11-22

[~kkolipaka] And this doesn't occur from ti info? I have 4 different installs of Windows running various VS combinations and cant reproduce it, [~cbarber] is setting up Windows now and I guess he'll check. This is just through and appc appc exec right?
Kondal Kolipaka 2017-11-22

[~eharris] Sorry! for the confusion. Problem is not with the VS path but with the http://jsonviewer.stack.hu which I generally use to view the json structure. Looks like formatting removing the spaces! Thanks [~ssekhri] for finding this!

JSON Source