[DAEMON-208] Enforce appcd version when loading plugins
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | Critical |
Status | Resolved |
Resolution | Fixed |
Resolution Date | 2017-12-14T23:21:44.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Appc Daemon 1.1.0 |
Components | appcd-plugin |
Labels | n/a |
Reporter | Chris Barber |
Assignee | Chris Barber |
Created | 2017-12-12T21:19:48.000+0000 |
Updated | 2017-12-14T23:21:44.000+0000 |
Description
We need a way to enforce that a plugin is compatible with specific appcd versions. We solve this by adding a
appcdVersion
to each plugin's package.json
. When the plugin is detected, the plugin system will check that the plugin is compatible.
This will lay the foundation for being able to inject appcd dependencies into plugins which solves issues of extraneous npm dependencies and instanceof
not working if object is not the same.
appc-daemon Master PR: https://github.com/appcelerator/appc-daemon/pull/248 appcd-plugin-android Master PR: https://github.com/appcelerator/appcd-plugin-android/pull/4 appcd-plugin-genymotion Master PR: https://github.com/appcelerator/appcd-plugin-genymotion/pull/1 appcd-plugin-ios Master PR: https://github.com/appcelerator/appcd-plugin-ios/pull/5 appcd-plugin-jdk Master PR: https://github.com/appcelerator/appcd-plugin-jdk/pull/1 appcd-plugin-system-info Master PR: https://github.com/appcelerator/appcd-plugin-system-info/pull/3 appcd-plugin-windows Master PR: https://github.com/appcelerator/appcd-plugin-windows/pull/1