[DAEMON-221] gulp upgrade: Run 'yarn' in top-level after updates and 'yarn upgrade' for each package
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Medium |
| Status | Resolved |
| Resolution | Fixed |
| Resolution Date | 2018-01-19T23:48:06.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Appc Daemon 1.1.0 |
| Components | Tooling |
| Labels | n/a |
| Reporter | Chris Barber |
| Assignee | Chris Barber |
| Created | 2018-01-16T16:40:44.000+0000 |
| Updated | 2018-01-19T23:48:07.000+0000 |
Description
The
gulp upgrade task does a good job of updating all of the npm dependencies in each package's package.json, but the top-level doesn't actually install the new deps. I think we simply need to remove the call to lerna bootstrap and call yarn.
Also, we never upgrade the dependencies of dependencies. We need to write temporary package.json files with no appcd-* deps, run yarn upgrade, then restore the original package.json. This will update the yarn.lock files.
PR: https://github.com/appcelerator/appc-daemon/pull/266