[DAEMON-224] Subscriptions not terminated if connection is reset
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Resolved |
Resolution | Fixed |
Resolution Date | 2018-01-23T17:26:48.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Appc Daemon 1.1.0 |
Components | appcd-core, appcd-http |
Labels | n/a |
Reporter | Chris Barber |
Assignee | Chris Barber |
Created | 2018-01-23T17:24:47.000+0000 |
Updated | 2018-01-23T17:26:48.000+0000 |
Description
If a client goes away, the WebSocketServer can emit an error
ECONNRESET
instead of emitting an "end" event.
We need to add better logging and also listen for errors so that we can end the internal subscription stream.
https://github.com/appcelerator/appc-daemon/pull/268