Titanium JIRA Archive
Appcelerator Daemon (DAEMON)

[DAEMON-235] appcd-fswatcher: Recursive fs watchers do not clean up when subdirectories are deleted

GitHub Issuen/a
TypeBug
PriorityHigh
StatusResolved
ResolutionFixed
Resolution Date2018-03-09T22:34:01.000+0000
Affected Version/sn/a
Fix Version/sAppc Daemon 1.1.0
Componentsappcd-fswatcher
Labelsn/a
ReporterChris Barber
AssigneeChris Barber
Created2018-02-14T23:11:02.000+0000
Updated2018-03-09T22:34:01.000+0000

Description

When recursive watching a directory, it will correctly emit change events for new subdirectories and start watching them. However if the subdirectories are deleted, the fs watcher continues to watch the non-existent node. 
new FSWatcher('/some/path', { depth: 1, recursive: true });

mkdir /some/path/foo
rmdir /some/path/foo
appcd status
It still continues to watch /some/path/foo.

Comments

  1. Chris Barber 2018-03-01

    PR: https://github.com/appcelerator/appc-daemon/pull/289
  2. Chris Barber 2018-03-09

    To test, run gulp coverage from the packages/appcd-fswatcher directory on all platforms. Then on Linux and macOS, run sudo gulp coverage.

JSON Source