Titanium JIRA Archive
Appcelerator Daemon (DAEMON)

[DAEMON-272] appcd-subprocess: Remove HTTP source check

GitHub Issuen/a
TypeImprovement
PriorityMedium
StatusResolved
ResolutionFixed
Resolution Date2019-02-15T03:31:19.000+0000
Affected Version/sn/a
Fix Version/sAppc Daemon 2.0.0
Componentsappcd-subprocess
Labelsn/a
ReporterChris Barber
AssigneeChris Barber
Created2019-02-14T23:28:36.000+0000
Updated2019-02-15T03:31:19.000+0000

Description

The SubprocessManager has a false security measure where only requests from internal routes and plugins and requests from WebSockets can spawn commands. Requests from HTTP are forbidden. Since WebSockets requests are essentially HTTP requests, there's no point blocking HTTP requests. The daemon's web server listens on localhost only, so there's no way for an outside actor to spawn a command. To make things worse, the check to see if the source is indeed "http" is broken. It checks if ctx.request.source is "http" when it should be checking ctx.source. This restriction is pointless and does not work. It should just be removed.

Comments

  1. Chris Barber 2019-02-14

    https://github.com/appcelerator/appc-daemon/pull/353

JSON Source