[DAEMON-306] iOS info missing watch info in simRuntimes with the cli 7.1.2-master.6
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2019-11-19T20:27:22.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Appc Daemon 3.2.0 |
Components | ioslib |
Labels | n/a |
Reporter | Satyam Sekhri |
Assignee | Ewan Harris |
Created | 2019-11-18T20:05:52.000+0000 |
Updated | 2019-12-02T16:46:09.000+0000 |
Description
When testing via studio the watch simulators were not shown when using Appc CLI 7.1.2-master.6. It works fine with older appc cli builds.
Running the command "appc appcd exec /ios/latest/info" noticed that the simRumtimes are missing the info related to watch.
This is on me and probably came about due to https://github.com/appcelerator/appc-cli/commit/c0924b5ef8033ef8863ae6192f2d34592860b15e there's maybe something bad in the ioslib@2.x sim detection
After some debugging we're not detecting the watchos runtimes due to [this check](https://github.com/appcelerator/ioslib/blob/1b1573cdf5936623457cc54947efae878880d192/src/xcode.js#L265-L267) where
runtime.version
(on my machine) is 6.1 and the iosRange is one of the keys in the object [here](https://github.com/appcelerator/ioslib/blob/1b1573cdf5936623457cc54947efae878880d192/src/simulator.js#L22-L128). I think the findDeviceTypesAndRuntimes function needs to be updated to check the WatchOS compatibility [~cbarber]?2_X PR: https://github.com/appcelerator/ioslib/pull/109 I'll setup the master PR once that's approved to avoid churn
master (v3.2.4) PR: https://github.com/appcelerator/ioslib/pull/111 2_X (v2.5.3) PR: https://github.com/appcelerator/ioslib/pull/110
Appc CLI updated to ioslib@2.5.3 - https://github.com/appcelerator/appc-cli/commit/18f7868a3823c6e93a59125daed7866933d0a16a
Verified the fix with 7.1.2.GA CLI core. Closing.