[DAEMON-329] node_winreglib.node is not a valid Win32 application

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Cannot Reproduce
Resolution Date	2020-03-31T20:12:07.000+0000
Affected Version/s	Appc Daemon 3.2.0
Fix Version/s	Appc Daemon 4.0.0
Components	winreglib
Labels	n/a
Reporter	Chris Barber
Assignee	Chris Barber
Created	2020-02-26T23:13:24.000+0000
Updated	2020-03-31T20:12:11.000+0000

Description

User installs Appc Daemon 3.2.0 with Node.js 10.13.0. When the daemon starts up, the Windows plugin cannot load winreglib:

{
  "stack": "PluginError: Failed to load plugin: \\\\?\\C:\\Users\\Test\\.appcelerator\\install\\8.0.0-master.10\\package\\node_modules\\winreglib\\build\\Release\\node_winreglib.node is not a valid Win32 application.\r\n\\\\?\\C:\\Users\\Test\\.appcelerator\\install\\8.0.0-master.10\\package\\node_modules\\winreglib\\build\\Release\\node_winreglib.node\n    at Object.Module._extensions..node (internal/modules/cjs/loader.js:807:18)\n    at PluginModule.load (internal/modules/cjs/loader.js:653:32)\n    at Function.load (C:\\Users\\Test\\.appcelerator\\install\\8.0.0-master.10\\package\\node_modules\\appcd-plugin\\dist\\plugin-module.js:71:11)\n    at PluginModule.require (C:\\Users\\Test\\.appcelerator\\install\\8.0.0-master.10\\package\\node_modules\\appcd-plugin\\dist\\plugin-module.js:142:23)\n    at require (C:\\Users\\Test\\.appcelerator\\install\\8.0.0-master.10\\package\\node_modules\\appcd-plugin\\dist\\plugin-module.js:181:36)\n    at load (C:\\Users\\Test\\.appcelerator\\install\\8.0.0-master.10\\package\\node_modules\\node-gyp-build\\index.js:21:10)\n    at Object.apply (C:\\Users\\Test\\.appcelerator\\install\\8.0.0-master.10\\package\\node_modules\\winreglib\\src\\index.js:2:46)\n    at PluginModule._compile (C:\\Users\\Test\\.appcelerator\\install\\8.0.0-master.10\\package\\node_modules\\appcd-plugin\\dist\\plugin-module.js:196:19)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)\n    at PluginModule.Module.load (internal/modules/cjs/loader.js:653:32)",
  "message": "Failed to load plugin: \\\\?\\C:\\Users\\Test\\.appcelerator\\install\\8.0.0-master.10\\package\\node_modules\\winreglib\\build\\Release\\node_winreglib.node is not a valid Win32 application.\r\n\\\\?\\C:\\Users\\Test\\.appcelerator\\install\\8.0.0-master.10\\package\\node_modules\\winreglib\\build\\Release\\node_winreglib.node",
  "status": 400,
  "statusCode": "400.1",
  "type": "error"
}

Note that winreglib uses N-API and is compatible with Node.js 10.2.0 and newer and that the Appc Daemon 3.2.0's core runs Node 10.16.3. This might be a Windows-only issue as Windows is general the only platform in which plugins are installed at daemon install time, Mac/Linux run into permission issues and have to resort to installing plugins at runtime. This behavior will change in DAEMON-311

Comments

Chris Barber 2020-03-04

Neither I nor [~ssekhri] can reproduce this now that DAEMON-330 has been fixed.
Chris Barber 2020-03-31

Reopened to change fix version.

JSON Source