[DAEMON-36] node-appc: fs watch doesn't properly handle symlinks
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | High |
Status | Resolved |
Resolution | Fixed |
Resolution Date | 2017-06-19T15:46:29.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Appc Daemon 1.0.0 |
Components | node-appc |
Labels | n/a |
Reporter | Chris Barber |
Assignee | Chris Barber |
Created | 2016-12-05T20:03:04.000+0000 |
Updated | 2017-06-19T15:46:38.000+0000 |
Description
The filesystem watch function doesn't properly handle symlinks. It doesn't check if a file/directory is a symlink.
The problem is when there's a symlinked directory to a parent directory or a directory that is being watched.
The fs watcher needs to detect a symlinked directory, then watch the real path, not the symlink. We still need to track the symlink directory, but it needs to make sure that changes to the real path are propagated to the watcher of the original path.
Fixed by DAEMON-6.