[DAEMON-100] appcd-plugin-jdk: JDK 9 is not detected
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Critical |
| Status | Resolved |
| Resolution | Fixed |
| Resolution Date | 2017-10-17T22:54:17.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Appc Daemon 1.0.0 |
| Components | jdklib |
| Labels | n/a |
| Reporter | Ewan Harris |
| Assignee | Chris Barber |
| Created | 2017-10-12T16:23:11.000+0000 |
| Updated | 2017-10-17T22:54:17.000+0000 |
Description
Description
JDK 9 has changed the registry key of Windows toHLKM\Software\JavaSoft\JDK. This needs to be added to [here](https://github.com/appcelerator/appc-daemon/blob/7d3c1dcb3766b7c8157fd68bcd07c1e51f658909/plugins/appcd-plugin-jdk/src/jdk-info-service.js#L158-L159)
Couple notes
- CurrentVersion returns 9, for JDK 8 it was 1.8
- jdklib currently fails to recognise JDK 9, it errors due to a missing JVM library, the jre folder no longer exists it seems. Will file a separate ticket for that
- There is no 32-bit JDK distributed https://stackoverflow.com/questions/46356345/can-java-9-run-on-a-32-bit-os but it can be built, we might not need to support detecting 32-bit if it is not distributed officially
Reg key added to plugin since https://github.com/appcelerator/appc-daemon/pull/75, jdklib just needs finishing to detect on ubuntu https://github.com/ewanharris/jdklib/tree/jdk9
https://github.com/appcelerator/jdklib/pull/6