{ "id": "170354", "key": "DAEMON-157", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "12519", "key": "DAEMON", "name": "Appcelerator Daemon" }, "fixVersions": [ { "id": "18407", "description": "", "name": "Appc Daemon 1.0.0", "archived": false, "released": true, "releaseDate": "2017-12-05" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2017-11-16T22:22:38.000+0000", "created": "2017-11-16T21:46:18.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [], "versions": [ { "id": "18407", "description": "", "name": "Appc Daemon 1.0.0", "archived": false, "released": true, "releaseDate": "2017-12-05" } ], "issuelinks": [], "assignee": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "updated": "2017-11-17T00:15:33.000+0000", "status": { "description": "A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.", "name": "Resolved", "id": "5", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "15049", "name": "appcd", "description": "Bootstrap, appcd CLI commands (start, stop, restart, exec, logcat, config, status)" } ], "description": "h5.Description\r\n\r\nIt was raised that the double banner when running {{appc appcd}} shouldn't happen, we should suppress this, I think we can use the APPC_ENV environment variable to do so, alternatively we could have the CLI push a {{--no-banner}} flag but I prefer the former", "attachment": [], "flagged": false, "summary": "appcd: Suppress banner when run through appc", "creator": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "subtasks": [], "reporter": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "environment": null, "closedSprints": [ { "id": 969, "state": "closed", "name": "2017 Sprint 23 Tooling", "startDate": "2017-11-05T16:36:50.292Z", "endDate": "2017-11-19T16:36:00.000Z", "completeDate": "2017-11-20T18:58:45.002Z", "originBoardId": 219 } ], "comment": { "comments": [ { "id": "430857", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "[~cbarber] Are you good with this change? I'll fold in with DAEMON-129 if so", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-11-16T22:01:04.000+0000", "updated": "2017-11-16T22:01:04.000+0000" }, { "id": "430858", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "Agreed. If the {{APPC_ENV}} is defined, appcd will suppress the banner.", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2017-11-16T22:01:18.000+0000", "updated": "2017-11-16T22:01:18.000+0000" }, { "id": "430873", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "Eurgh, sorry [~cbarber] that doesn't seem to be taking on my Windows machine. Shall we add {{process.env.APPC_ENV = true;}} to appc-cli here [here|https://github.com/appcelerator/appc-cli/blob/8594e625681243c21e28fb242ce7501f13223258/bin/commands/appcd.js#L32] for simplicity?", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-11-16T23:38:18.000+0000", "updated": "2017-11-16T23:38:18.000+0000" }, { "id": "430878", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "How about {{process.env.hasOwnProperty('APPC_ENV')}}?", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2017-11-17T00:13:42.000+0000", "updated": "2017-11-17T00:13:42.000+0000" }, { "id": "430879", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "Fixed https://github.com/appcelerator/appc-daemon/pull/158", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2017-11-17T00:15:33.000+0000", "updated": "2017-11-17T00:15:33.000+0000" } ], "maxResults": 5, "total": 5, "startAt": 0 } } }