[DAEMON-188] appcd-plugin-windows: Remove dummy device when we have more than one device
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | High |
| Status | Resolved |
| Resolution | Fixed |
| Resolution Date | 2017-11-27T16:19:35.000+0000 |
| Affected Version/s | Appc Daemon 1.0.0 |
| Fix Version/s | Appc Daemon 1.0.0 |
| Components | appcd-plugin-windows |
| Labels | n/a |
| Reporter | Ewan Harris |
| Assignee | Ewan Harris |
| Created | 2017-11-23T18:05:22.000+0000 |
| Updated | 2017-11-27T16:19:35.000+0000 |
Description
Description
windowslib inserts a dummy device on detection { name: 'Device', udid: 0, index: 0, wpsdk: null, type: 'device' } even when no devices are detected, when running ti info because titanium does a top level windowslib.detect vs a windowslib.devices.detect, it doesnt have this device as windowslib will remove. We need to build in logic to the device detection to remove the dummy device if we have more than one device I think windowslib does it somewhere around here https://github.com/appcelerator/windowslib/blob/master/lib/wptool.js#L316-L335Comments
- Ewan Harris 2017-11-24 https://github.com/appcelerator/appc-daemon/pull/194 We really need to rewrite windowslib