{
	"id": "170533",
	"key": "DAEMON-201",
	"fields": {
		"issuetype": {
			"id": "4",
			"description": "An improvement or enhancement to an existing feature or task.",
			"name": "Improvement",
			"subtask": false
		},
		"project": {
			"id": "12519",
			"key": "DAEMON",
			"name": "Appcelerator Daemon"
		},
		"fixVersions": [
			{
				"id": "19959",
				"description": "",
				"name": "Appc Daemon 1.1.0",
				"archived": false,
				"released": true,
				"releaseDate": "2018-04-09"
			},
			{
				"id": "20044",
				"description": "",
				"name": "Appc Daemon 1.0.1",
				"archived": false,
				"released": true,
				"releaseDate": "2017-12-15"
			}
		],
		"resolution": {
			"id": "1",
			"description": "A fix for this issue is checked into the tree and tested.",
			"name": "Fixed"
		},
		"resolutiondate": "2017-12-05T16:18:18.000+0000",
		"created": "2017-12-04T14:53:43.000+0000",
		"priority": {
			"name": "None",
			"id": "6"
		},
		"labels": [],
		"versions": [
			{
				"id": "18407",
				"description": "",
				"name": "Appc Daemon 1.0.0",
				"archived": false,
				"released": true,
				"releaseDate": "2017-12-05"
			}
		],
		"issuelinks": [],
		"assignee": {
			"name": "eharris",
			"key": "eharris",
			"displayName": "Ewan Harris",
			"active": true,
			"timeZone": "Europe/Dublin"
		},
		"updated": "2017-12-12T21:25:24.000+0000",
		"status": {
			"description": "A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.",
			"name": "Resolved",
			"id": "5",
			"statusCategory": {
				"id": 3,
				"key": "done",
				"colorName": "green",
				"name": "Done"
			}
		},
		"components": [
			{
				"id": "15603",
				"name": "appcd-client"
			}
		],
		"description": "h5.Description\r\n\r\nI was reviewing the test failures and noticed some Jenkins machines fail on the below test, as I understand it it's possible for the locale function in appcd-response to return null, so I believe it would make sense for appcd-client to have a default for the Accepts-Language header, which would probably be {{en}} or {{*}}.\r\n\r\nAlternatively just fix the regex check to accept null.\r\n\r\n{code}\r\n 1) Client request() should make a request to the mock server:\r\n     AssertionError: expected 'null' to match /^([a-z]{2})(?:[-_](?:\\w+[-_])?([A-Z]{2}))?$/i\r\n      at WebSocket.conn.on.msg (test/test-client.js:159:49)\r\n      at Receiver._receiver.onmessage (/Users/build/jenkins/workspace/cli_appc-daemon_master-XS2WQ2LFI3NLAO73KGNRAF6P26KUCWWAZBYDRU2BBMG2YHPP363A/node_modules/ws/lib/WebSocket.js:143:47)\r\n      at Receiver.dataMessage (/Users/build/jenkins/workspace/cli_appc-daemon_master-XS2WQ2LFI3NLAO73KGNRAF6P26KUCWWAZBYDRU2BBMG2YHPP363A/node_modules/ws/lib/Receiver.js:389:14)\r\n      at Receiver.getData (/Users/build/jenkins/workspace/cli_appc-daemon_master-XS2WQ2LFI3NLAO73KGNRAF6P26KUCWWAZBYDRU2BBMG2YHPP363A/node_modules/ws/lib/Receiver.js:330:12)\r\n      at Receiver.startLoop (/Users/build/jenkins/workspace/cli_appc-daemon_master-XS2WQ2LFI3NLAO73KGNRAF6P26KUCWWAZBYDRU2BBMG2YHPP363A/node_modules/ws/lib/Receiver.js:165:16)\r\n      at Receiver.add (/Users/build/jenkins/workspace/cli_appc-daemon_master-XS2WQ2LFI3NLAO73KGNRAF6P26KUCWWAZBYDRU2BBMG2YHPP363A/node_modules/ws/lib/Receiver.js:139:10)\r\n      at Socket._ultron.on (/Users/build/jenkins/workspace/cli_appc-daemon_master-XS2WQ2LFI3NLAO73KGNRAF6P26KUCWWAZBYDRU2BBMG2YHPP363A/node_modules/ws/lib/WebSocket.js:139:22)\r\n      at addChunk (_stream_readable.js:263:12)\r\n      at readableAddChunk (_stream_readable.js:250:11)\r\n      at Socket.Readable.push (_stream_readable.js:208:10)\r\n      at TCP.onread (net.js:594:20)\r\n{code}",
		"attachment": [],
		"flagged": false,
		"summary": "appcd-client: Accept-Language should not be set if locale is null",
		"creator": {
			"name": "eharris",
			"key": "eharris",
			"displayName": "Ewan Harris",
			"active": true,
			"timeZone": "Europe/Dublin"
		},
		"subtasks": [],
		"reporter": {
			"name": "eharris",
			"key": "eharris",
			"displayName": "Ewan Harris",
			"active": true,
			"timeZone": "Europe/Dublin"
		},
		"environment": null,
		"closedSprints": [
			{
				"id": 977,
				"state": "closed",
				"name": "2017 Sprint 25 Tooling",
				"startDate": "2017-12-03T23:21:41.825Z",
				"endDate": "2017-12-17T23:21:00.000Z",
				"completeDate": "2017-12-18T22:30:55.005Z",
				"originBoardId": 219
			}
		],
		"comment": {
			"comments": [
				{
					"id": "431676",
					"author": {
						"name": "cbarber",
						"key": "cbarber",
						"displayName": "Chris Barber",
						"active": true,
						"timeZone": "America/Chicago"
					},
					"body": "{{locale()}} returning {{null}} is valid. {{appcd-client}} should probably only set the {{Accept-Language}} if the locale is not {{null}}.\r\n\r\nInternally, the {{WebSocketSession}} will pass the {{Accept-Language}} value to the {{appcd-response}} {{Message.toString()}} which in turn tolerates {{null}} locales.\r\n\r\nSo this ticket comes down to not setting the locale if it's {{null}} and fixing the unit test in the event locale is {{null}}.",
					"updateAuthor": {
						"name": "cbarber",
						"key": "cbarber",
						"displayName": "Chris Barber",
						"active": true,
						"timeZone": "America/Chicago"
					},
					"created": "2017-12-04T16:09:39.000+0000",
					"updated": "2017-12-04T16:09:39.000+0000"
				},
				{
					"id": "431724",
					"author": {
						"name": "eharris",
						"key": "eharris",
						"displayName": "Ewan Harris",
						"active": true,
						"timeZone": "Europe/Dublin"
					},
					"body": "https://github.com/appcelerator/appc-daemon/pull/220",
					"updateAuthor": {
						"name": "eharris",
						"key": "eharris",
						"displayName": "Ewan Harris",
						"active": true,
						"timeZone": "Europe/Dublin"
					},
					"created": "2017-12-05T13:06:51.000+0000",
					"updated": "2017-12-05T13:06:51.000+0000"
				},
				{
					"id": "432036",
					"author": {
						"name": "cbarber",
						"key": "cbarber",
						"displayName": "Chris Barber",
						"active": true,
						"timeZone": "America/Chicago"
					},
					"body": "1_0_X backport: https://github.com/appcelerator/appc-daemon/pull/247",
					"updateAuthor": {
						"name": "cbarber",
						"key": "cbarber",
						"displayName": "Chris Barber",
						"active": true,
						"timeZone": "America/Chicago"
					},
					"created": "2017-12-12T16:56:03.000+0000",
					"updated": "2017-12-12T16:56:03.000+0000"
				}
			],
			"maxResults": 3,
			"total": 3,
			"startAt": 0
		}
	}
}