[DAEMON-207] "appc appcd restart" does not restart the daemon but keeps on adding appcd-plugin-host processes which keep running & consume memory

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2017-12-12T04:25:28.000+0000
Affected Version/s	Appc Daemon 1.0.0
Fix Version/s	Appc Daemon 1.1.0, Appc Daemon 1.0.1
Components	appcd, appcd-plugin
Labels	n/a
Reporter	Lokesh Choudhary
Assignee	Chris Barber
Created	2017-12-11T18:48:53.000+0000
Updated	2017-12-19T00:04:09.000+0000

Description

Steps to reproduce:

1. Do a appc appcd restart in the command prompt.

Actual results:

1. The daemon does not restart (Not sure if it does restart internally, but gives wrong message that it didn't in the terminal).

ITEM-AX44549:QEUtility-Node lchoudhary$ 
ITEM-AX44549:QEUtility-Node lchoudhary$ appc appcd restart

Appc Daemon already started
ITEM-AX44549:QEUtility-Node lchoudhary$ appc appcd restart

Appc Daemon already started
ITEM-AX44549:QEUtility-Node lchoudhary$ appc appcd restart

Appc Daemon already started
ITEM-AX44549:QEUtility-Node lchoudhary$ appc appcd restart

Appc Daemon already started
ITEM-AX44549:QEUtility-Node lchoudhary$ appc appcd restart

Appc Daemon already started
ITEM-AX44549:QEUtility-Node lchoudhary$ appc appcd restart

Appc Daemon already started
ITEM-AX44549:QEUtility-Node lchoudhary$ appc appcd restart

Appc Daemon already started
ITEM-AX44549:QEUtility-Node lchoudhary$ appc appcd restart

Appc Daemon already started
ITEM-AX44549:QEUtility-Node lchoudhary$ appc appcd restart

Appc Daemon already started
ITEM-AX44549:QEUtility-Node lchoudhary$ appc appcd restart

Appc Daemon already started

2. It also keeps on adding appcd-plugin-host processes after each restart command run. These processes stay running & consume memory. (Attached a screenshot for reference).

Expected results:

1. Daemon should restart successfully every time command is run & should not keep on adding new appcd-plugin-host processes or kill/stop the old ones.

Attachments

File	Date	Size
appcd_dump.txt	2017-12-11T18:48:31.000+0000	4366678
Screen Shot 2017-12-10 at 5.40.56 PM.png	2017-12-11T18:48:10.000+0000	236089
Screen Shot 2017-12-11 at 10.04.12 AM.png	2017-12-11T18:47:57.000+0000	565813
Screen Shot 2017-12-11 at 10.37.49 AM.png	2017-12-11T18:48:22.000+0000	559009

Comments

Abir Mukherjee 2017-12-11 I am able to reproduce this issue. I need to run: killall -9 appcd-plugin-host to successfully kill all the running append-plugin-host processes.
Chris Barber 2017-12-12 Master PR: https://github.com/appcelerator/appc-daemon/pull/241 1_0_X PR: https://github.com/appcelerator/appc-daemon/pull/242
Lokesh Choudhary 2017-12-19 Verified the fix with Daemon 1.0.1. Doing a appc appcd restart does restart daemon & does not spin up extra appcd-plugin-host processes. The old processes are killed & new ones are started. Closing. Studio Ver: 5.0.0.201712081732 SDK Ver: 7.0.1.v20171218094049 OS Ver: 10.12.3 Xcode Ver: Xcode 8.3.3 Appc NPM: 4.2.11 Appc CLI: 7.0.1-master.5 Daemon Ver: 1.0.1 Ti CLI Ver: 5.0.14 Alloy Ver: 1.10.10 Node Ver: 8.9.1 Java Ver: 1.8.0_101

JSON Source