[DAEMON-213] Plugin should fail to load if appcd in package.json is not an object
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | High |
| Status | Resolved |
| Resolution | Fixed |
| Resolution Date | 2018-01-02T17:48:08.000+0000 |
| Affected Version/s | Appc Daemon 1.1.0 |
| Fix Version/s | Appc Daemon 1.1.0 |
| Components | appcd-plugin |
| Labels | regression |
| Reporter | Ewan Harris |
| Assignee | Ewan Harris |
| Created | 2018-01-02T15:00:00.000+0000 |
| Updated | 2018-01-02T17:48:08.000+0000 |
Description
Description
https://github.com/appcelerator/appc-daemon/blob/master/packages/appcd-plugin/test/test-plugin.js#L68-L71 is failing as the Object.assign call here https://github.com/appcelerator/appc-daemon/blob/master/packages/appcd-plugin/src/plugin.js#L149 is always making sure that appcd is an object. There's also a few failures in appcd-plugin around error messages etc.Comments
- Ewan Harris 2018-01-02 https://github.com/appcelerator/appc-daemon/pull/252