[DAEMON-219] Dump: Errors and warnings not shown in the log

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Resolved
Resolution	Fixed
Resolution Date	2018-01-19T23:48:14.000+0000
Affected Version/s	Appc Daemon 1.1.0
Fix Version/s	Appc Daemon 1.1.0
Components	appcd
Labels	n/a
Reporter	Ewan Harris
Assignee	Chris Barber
Created	2018-01-12T11:28:05.000+0000
Updated	2018-01-19T23:48:14.000+0000

Description

When running appcd dump I noticed that errors and warnings don't seem to be logged. For example in the attached appcd-dump.json the object at line 14580 should represent the below error

2018-01-12T11:05:41.653Z appcd:core:websocket-session [10] 127.0.0.1:57851 /foo/bar 404 Not Found 1ms
2018-01-12T11:05:41.653Z appcd:core:websocket-session error { DispatcherError: Not Found (code 404)
2018-01-12T11:05:41.653Z appcd:core:websocket-session error     at dispatch (/Users/eharris/Documents/git/appc-daemon/packages/appcd-dispatcher/dist/src/dispatcher.js:137:11)
2018-01-12T11:05:41.653Z appcd:core:websocket-session error     at dispatch (/Users/eharris/Documents/git/appc-daemon/packages/appcd-dispatcher/dist/src/dispatcher.js:144:12)
2018-01-12T11:05:41.653Z appcd:core:websocket-session error     at dispatch (/Users/eharris/Documents/git/appc-daemon/packages/appcd-dispatcher/dist/src/dispatcher.js:144:12)
2018-01-12T11:05:41.653Z appcd:core:websocket-session error     at dispatch (/Users/eharris/Documents/git/appc-daemon/packages/appcd-dispatcher/dist/src/dispatcher.js:144:12)
2018-01-12T11:05:41.653Z appcd:core:websocket-session error     at dispatch (/Users/eharris/Documents/git/appc-daemon/packages/appcd-dispatcher/dist/src/dispatcher.js:144:12)
2018-01-12T11:05:41.653Z appcd:core:websocket-session error     at dispatch (/Users/eharris/Documents/git/appc-daemon/packages/appcd-dispatcher/dist/src/dispatcher.js:144:12)
2018-01-12T11:05:41.653Z appcd:core:websocket-session error     at dispatch (/Users/eharris/Documents/git/appc-daemon/packages/appcd-dispatcher/dist/src/dispatcher.js:144:12)
2018-01-12T11:05:41.653Z appcd:core:websocket-session error     at dispatch (/Users/eharris/Documents/git/appc-daemon/packages/appcd-dispatcher/dist/src/dispatcher.js:144:12)
2018-01-12T11:05:41.653Z appcd:core:websocket-session error     at dispatch (/Users/eharris/Documents/git/appc-daemon/packages/appcd-dispatcher/dist/src/dispatcher.js:144:12)
2018-01-12T11:05:41.653Z appcd:core:websocket-session error     at dispatch (/Users/eharris/Documents/git/appc-daemon/packages/appcd-dispatcher/dist/src/dispatcher.js:144:12) id: '7b5f0598-3581-42a7-acba-8e97421bc519' }
2018-01-12T11:05:41.661Z appcd:http:webserver 127.0.0.1:57851 closed WebSocket
2018-01-12T11:05:41.662Z appcd:http:webserver 127.0.0.1:57851 disconnected

Steps to repro

Ensure the daemon is started and you're watching the logs

`appcd exec /foo/bar`

`appcd dump --view`

Actual

Errors and warnings are not shown in the log output

Expected

Errors and warnings should be shown

Attachments

File	Date	Size
appcd-dump.json	2018-01-12T11:05:57.000+0000	480735

Comments

Chris Barber 2018-01-19

PR: https://github.com/appcelerator/appc-daemon/pull/266

JSON Source