Titanium JIRA Archive
Appcelerator Daemon (DAEMON)

[DAEMON-287] Remove winreglib dependency from appcd-response

GitHub Issuen/a
TypeImprovement
PriorityHigh
StatusResolved
ResolutionFixed
Resolution Date2019-10-25T19:24:07.000+0000
Affected Version/sn/a
Fix Version/sAppc Daemon 3.1.0
Componentsappcd-response
Labelsn/a
ReporterChris Barber
AssigneeChris Barber
Created2019-10-24T17:22:25.000+0000
Updated2019-10-25T19:24:07.000+0000

Description

appcd-response is used by several packages such as appcd-subprocess which is used by non-appcd projects. appcd-response needs to detect the locale in order to display the appropriate message. On Windows machines, the locale is retrieved from the Windows Registry. Previously, appcd-response@1.x uses appcd-winreg (now deprecated) which in turned used winreg to simply spawn the reg.exe command and query the registry. When appcd-winreg was sunset, it was replaced with the new winreglib, a native Node.js addon. Now when a non-appcd project uses something like appcd-subprocess, it will depend on winreglib and that complicates install issues for specific environments such as Atom plugins on Linux. The solution here is to replace appcd-response's winreglib dependency with two simple spawnSync() calls.

Comments

  1. Chris Barber 2019-10-24

    PR: https://github.com/appcelerator/appc-daemon/pull/437

JSON Source