[DAEMON-310] @appcd/plugin-android: Fails to start with Error: Recursively watching root is not permitted

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2020-03-31T20:13:07.000+0000
Affected Version/s	Appc Daemon 3.2.0
Fix Version/s	Appc Daemon 4.0.0
Components	appcd-plugin-android
Labels	n/a
Reporter	Ewan Harris
Assignee	Chris Barber
Created	2020-01-14T10:22:10.000+0000
Updated	2020-03-31T20:13:09.000+0000

Description

H5.Description When attempting to start the android plugin I'm getting the below error, this works fine on CLI 7.1.2 (plugin version 1.3.0/appcd version 1.1.3) and CLI 8.0.0-master.4 (plugin version 1.5.2/appcd 3.1.0) (note are we not choosing to lock down plugin versions per default-plugin release, this re-introduces the risk that we had previously worked to eliminate)

{
  "stack": "Error: Recursively watching root is not permitted\n    at register (/Users/awam/git/appc-cli/node_modules/appcd-fswatcher/dist/fswatcher.js:967:10)\n    at new FSWatcher (/Users/awam/git/appc-cli/node_modules/appcd-fswatcher/dist/fswatcher.js:893:19)\n    at FSWatchManager.onSubscribe (/Users/awam/git/appc-cli/node_modules/appcd-fswatch-manager/dist/fswatch-manager.js:81:19)\n    at FSWatchManager.subscribe (/Users/awam/git/appc-cli/node_modules/appcd-dispatcher/dist/service-dispatcher.js:206:18)\n    at FSWatchManager.handler (/Users/awam/git/appc-cli/node_modules/appcd-dispatcher/dist/service-dispatcher.js:108:11)\n    at dispatch (/Users/awam/git/appc-cli/node_modules/appcd-dispatcher/dist/dispatcher.js:196:23)\n    at Dispatcher.call (/Users/awam/git/appc-cli/node_modules/appcd-dispatcher/dist/dispatcher.js:230:16)\n    at dispatch (/Users/awam/git/appc-cli/node_modules/appcd-dispatcher/dist/dispatcher.js:189:26)\n    at dispatch (/Users/awam/git/appc-cli/node_modules/appcd-dispatcher/dist/dispatcher.js:172:12)\n    at dispatch (/Users/awam/git/appc-cli/node_modules/appcd-dispatcher/dist/dispatcher.js:172:12)\n    at dispatch (/Users/awam/git/appc-cli/node_modules/appcd-dispatcher/dist/dispatcher.js:172:12)\n    at dispatch (/Users/awam/git/appc-cli/node_modules/appcd-dispatcher/dist/dispatcher.js:172:12)\n    at Dispatcher.call (/Users/awam/git/appc-cli/node_modules/appcd-dispatcher/dist/dispatcher.js:230:16)\n    at Function.call (/Users/awam/git/appc-cli/node_modules/appcd-dispatcher/dist/dispatcher.js:84:26)\n    at handler (/Users/awam/git/appc-cli/node_modules/appcd-plugin/dist/external-plugin.js:519:55)\n    at EventEmitter.onMessage (/Users/awam/git/appc-cli/node_modules/appcd-plugin/dist/tunnel.js:92:4)",
  "message": "Recursively watching root is not permitted",
  "status": 400,
  "statusCode": "400.1",
  "type": "error"
}

Steps to reproduce

1. Install appc cli 8.0.0-master.5 from preprod 2. Start the daemon appc appcd start 3. Call the android endpoints appc appcd exec /android/1.x/info and appc appcd exec /android/2.x/info

Actual

Above error

Expected

No error, android info should be returned

Attachments

File	Date	Size
out.dump	2020-01-14T10:27:16.000+0000	466690
out.txt	2020-01-14T10:27:16.000+0000	265327

Comments

Ewan Harris 2020-01-14

Attached a dump file and logcat
Chris Barber 2020-01-14

3 year old bug in appcd-path. PR: https://github.com/appcelerator/appc-daemon/pull/451
Lokesh Choudhary 2020-02-19

Verified the fix with 8.0.0-master.6. Closing.
Chris Barber 2020-03-31

Reopened to change fix version.

JSON Source