[DAEMON-32] Windows: jdklib v2 - If you move your JDK while running jdklib.watch(), then "TypeError: Path must be a string" error is returned

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Resolved
Resolution	Invalid
Resolution Date	2017-10-17T03:53:20.000+0000
Affected Version/s	n/a
Fix Version/s	n/a
Components	jdklib
Labels	n/a
Reporter	Wilson Luu
Assignee	Chris Barber
Created	2016-08-30T00:53:30.000+0000
Updated	2017-10-17T03:53:20.000+0000

Description

*Details:* On Windows, if you move your JDK while running jdklib.watch(), then TypeError: Path must be a string error is returned. *Notes:* This is not reproducible with JDK on Mac. *Steps to reproduce:*

Make sure you are using Node 4.X.X on Windows

Clone and run `npm install` on https://github.com/appcelerator/jdklib

Symlink to the above built jdklib v2

Run this Node script:

'use strict';

const jdklib = require('jdklib');

jdklib
    .watch()
    .on('results', results => {
        console.log(JSON.stringify(results, null, 4));
    });

Find your JDK and move it

*Actual:* TypeError: Path must be a string error is returned:

TypeError: Path must be a string. Received null
    at assertPath (path.js:8:11)
    at Object.win32.join (path.js:221:5)
    at Watcher.onChange (C:\Users\qe\Desktop\something\node_modules\jdklib\node_modules\node-appc\dist\fs.js:270:19)
    at emitTwo (events.js:87:13)
    at FSWatcher.emit (events.js:172:7)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1221:12)

*Expected:* No errors should be returned while watching the JDK.

Attachments

File	Date	Size
bug.gif	2016-08-30T00:53:28.000+0000	771907

Comments

Chris Barber 2017-02-14

This ticket is probably no longer valid. Must wait a while longer before it can be re-validated.
Chris Barber 2017-10-17

This issue is no longer valid.

JSON Source