[DAEMON-340] Plugins fail on startup on Windows

GitHub Issue	n/a
Type	Bug
Priority	None
Status	Resolved
Resolution	Fixed
Resolution Date	2021-04-15T02:57:57.000+0000
Affected Version/s	n/a
Fix Version/s	Appc Daemon 4.0.3
Components	appcd-util
Labels	n/a
Reporter	Ewan Harris
Assignee	Ewan Harris
Created	2021-04-14T22:37:38.000+0000
Updated	2021-04-15T14:12:57.000+0000

Description

It's erroring during redaction because process.env.HOME isn't always set on Windows, so it should use os.homedir most likely 'TypeError: Cannot read property 'replace' of undefined at addReplacement (C:\Users\awam\AppData\Roaming\npm\node_modules\appcd\node_modules\appcd-util\dist\util.js:764:40) at redact (C:\Users\awam\AppData\Roaming\npm\node_modules\appcd\node_modules\appcd-util\dist\util.js:681:2) at map (C:\Users\awam\AppData\Roaming\npm\node_modules\appcd\node_modules\appcd-plugin\dist\tunnel-stream.js:40:14) at Array.map () at TunnelStream._write (C:\Users\awam\AppData\Roaming\npm\node_modules\appcd\node_modules\appcd-plugin\dist\tunnel-stream.js:34:33) at writeOrBuffer (internal/streams/writable.js:358:12) at TunnelStream.write (internal/streams/writable.js:303:10) at SnoopLogg.dispatch (C:\Users\awam\AppData\Roaming\npm\node_modules\appcd\node_modules\snooplogg\dist\index.js:451:14) at process.onSnoopMessage (C:\Users\awam\AppData\Roaming\npm\node_modules\appcd\node_modules\snooplogg\dist\index.js:625:10) at process.emit (events.js:315:20)

Comments

Ewan Harris 2021-04-14 PR: https://github.com/appcelerator/appc-daemon/pull/525

JSON Source