[DAEMON-99] appcd-plugin: Plugin host spawns a new console window on Windows
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | High |
| Status | Resolved |
| Resolution | Fixed |
| Resolution Date | 2017-10-25T16:04:01.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Appc Daemon 1.0.0 |
| Components | appcd-plugin |
| Labels | n/a |
| Reporter | Ewan Harris |
| Assignee | Ewan Harris |
| Created | 2017-10-12T15:10:34.000+0000 |
| Updated | 2017-10-26T02:59:22.000+0000 |
Description
Description
On Windows when calling to a plugin (for example appcd exec /jdk/latest/info) a new node console window is spawned. This window then stays open until it's either killed by a user or the daemon is stopped. This could be problematic as it means that spawned plugins can pretty much die at the whim of a user. I'm not sure whether it's fully possible to suppress the window however, recent PR into node might add that behaviour though https://github.com/nodejs/node/pull/15380Comments
- Chris Barber 2017-10-12 We've seen this before, specifically with launching the Android Emulator. I'll take a look.
- Ewan Harris 2017-10-19 Trying out https://github.com/nodejs/node/pull/15380 in https://nodejs.org/download/nightly/v9.0.0-nightly2017101870832bc353/ and the console window is no longer shown constantly, there is however a brief flash as the plugin spawns
- Ewan Harris 2017-10-19 PR to wire up windowsHide into subprocess https://github.com/appcelerator/appc-daemon/pull/87