[MOD-2272] TouchId Module: isSupported() return TRUE even for iPhone4S and iPhone 5 which doesn't have finger print sensor.
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2016-07-13T21:15:49.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 6.0.0, Release 5.4.0 |
Components | TouchID |
Labels | qe-5.4.0 |
Reporter | Shuo Liang |
Assignee | Angel Petkov |
Created | 2016-07-13T03:48:59.000+0000 |
Updated | 2016-07-26T17:47:07.000+0000 |
Description
isSupported() return TRUE even for iPhone4S and iPhone 5 which doesn't have finger print sensor.
Use demo-code from repo. PR:https://github.com/appcelerator-modules/ti.touchid/pull/20
Fixed, good job!
[~sliang] the fix is in 5.4.0.v20160713141635
Exactly. As discussed during review, if a device is not set-up for TouchID, it will return FALSE, because the check is context-based. *EDIT*: Also updated the [Releases tab](https://github.com/appcelerator-modules/ti.touchid/releases/tag/iOS-1.2.2) *EDIT2*: See [this video](https://youtu.be/uQs1HXYnFKY) for a demonstration. If the user has TouchID but didn't activate it, it is not supported *in the current app-context*. As soon as he activates it and calls the check again, it will return true.
Verified as fixed, Here are the results from the following cases: *iPhone 4S:* returned FALSE. *iPhone 5S with FingerPrint Set:* returned TRUE. *iPhone 5S without FingerPrint Set:* returned FALSE. *iPhone 5:* returned FALSE. _Tested with iOS8._ Tested On: Mac OSX El Capitan 10.11.5 Ti SDK: 5.4.0.v20160725003348 Appc Studio: 4.7.0.201607111053 Appc NPM: 4.2.7 App CLI: 5.4.0-34 Xcode 7.3 Node v4.4.7 *Closing ticket.*