[MOD-2283] Facebook module 5.2.0 does not compile

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2016-08-22T07:04:58.000+0000
Affected Version/s	Release 5.2.0
Fix Version/s	Release 5.5.0
Components	Map
Labels	android, assets, facebook, regression
Reporter	Ganna Kozynenko
Assignee	Ashraf Abu
Created	2016-08-18T09:54:29.000+0000
Updated	2018-08-06T17:49:10.000+0000

Description

I have tried to compile with Facebook 5.2.0 on Android, but it gives errors in resources:

[ERROR] :  Failed to package application:
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable-hdpi-v4/com_facebook_button_like_icon_selected.png: error: Duplicate file.
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable-hdpi/com_facebook_button_like_icon_selected.png: Original is here. The version qualifier may be implied.

I tried to remove -v4 folders, but then it gives other many errors (seems like not related to duplicated icons):

[ERROR] :  Failed to package application:
[ERROR] :  
[ERROR] :  warning: string 'com_facebook_device_auth_instructions' has no default translation.
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/layout/com_facebook_device_auth_dialog_fragment.xml:45: error: Error: No resource found that matches the given name (at 'src' with value '@drawable/com_facebook_favicon_white').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/layout/com_facebook_device_auth_dialog_fragment.xml:70: error: Error: No resource found that matches the given name (at 'textColor' with value '@color/com_facebook_device_auth_text').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/layout/com_facebook_device_auth_dialog_fragment.xml:88: error: Error: No resource found that matches the given name (at 'textColor' with value '@color/com_facebook_device_auth_text').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/layout/com_facebook_device_auth_dialog_fragment.xml:117: error: Error: No resource found that matches the given name (at 'textColor' with value '@color/com_facebook_device_auth_text').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_auth_dialog_background.xml:24: error: Error: No resource found that matches the given name (at 'bottomLeftRadius' with value '@dimen/com_facebook_auth_dialog_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_auth_dialog_background.xml:24: error: Error: No resource found that matches the given name (at 'bottomRightRadius' with value '@dimen/com_facebook_auth_dialog_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_auth_dialog_background.xml:24: error: Error: No resource found that matches the given name (at 'topLeftRadius' with value '@dimen/com_facebook_auth_dialog_corner_radius_oversized').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_auth_dialog_background.xml:24: error: Error: No resource found that matches the given name (at 'topRightRadius' with value '@dimen/com_facebook_auth_dialog_corner_radius_oversized').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_auth_dialog_header_background.xml:24: error: Error: No resource found that matches the given name (at 'topLeftRadius' with value '@dimen/com_facebook_auth_dialog_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_auth_dialog_header_background.xml:24: error: Error: No resource found that matches the given name (at 'topRightRadius' with value '@dimen/com_facebook_auth_dialog_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_background.xml:26: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_background.xml:27: error: Error: No resource found that matches the given name (at 'color' with value '@color/com_facebook_button_background_color_focused_disabled').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_background.xml:33: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_background.xml:39: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_background.xml:40: error: Error: No resource found that matches the given name (at 'color' with value '@color/com_facebook_button_background_color_focused').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_background.xml:41: error: Error: No resource found that matches the given name (at 'color' with value '@color/com_facebook_button_border_color_focused').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_background.xml:49: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_background.xml:55: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_icon.xml:23: error: Error: No resource found that matches the given name (at 'drawable' with value '@drawable/com_facebook_button_icon_blue').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_icon.xml:24: error: Error: No resource found that matches the given name (at 'drawable' with value '@drawable/com_facebook_button_icon_white').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_like_background.xml:25: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_like_background.xml:32: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_like_background.xml:33: error: Error: No resource found that matches the given name (at 'color' with value '@color/com_facebook_button_background_color_focused_disabled').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_like_background.xml:39: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_like_background.xml:45: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_like_background.xml:46: error: Error: No resource found that matches the given name (at 'color' with value '@color/com_facebook_button_background_color_focused').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_like_background.xml:51: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_like_background.xml:52: error: Error: No resource found that matches the given name (at 'color' with value '@color/com_facebook_button_background_color_selected').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_like_background.xml:57: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_login_silver_background.xml:25: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_login_silver_background.xml:31: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_login_silver_background.xml:37: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_send_background.xml:26: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_send_background.xml:27: error: Error: No resource found that matches the given name (at 'color' with value '@color/com_facebook_button_background_color_focused_disabled').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_send_background.xml:33: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_send_background.xml:39: error: Error: No resource found that matches the given name (at 'radius' with value '@dimen/com_facebook_button_corner_radius').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_send_background.xml:40: error: Error: No resource found that matches the given name (at 'color' with value '@color/com_facebook_button_background_color_focused').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_button_send_background.xml:41: error: Error: No resource found that matches the given name (at 'color' with value '@color/com_facebook_button_border_color_focused').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_send_button_icon.xml:23: error: Error: No resource found that matches the given name (at 'drawable' with value '@drawable/com_facebook_button_send_icon_blue').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/drawable/com_facebook_send_button_icon.xml:24: error: Error: No resource found that matches the given name (at 'drawable' with value '@drawable/com_facebook_button_send_icon_white').
[ERROR] :  
[ERROR] :  /Users/annakozy/Appcelerator.Studio/front/build/android/res/color/com_facebook_send_button_text_color.xml:22: error: Error: No resource found that matches the given name (at 'color' with value '@color/com_facebook_messenger_blue').

Comments

Hans Knöchel 2016-08-18

[~annakozy@direcciona.me] Can you confirm that it worked with previews versions of Ti.Facebook Android (like [4.0.5](https://github.com/appcelerator-modules/ti.facebook/releases/tag/android-4.0.5))?
Hans Knöchel 2016-08-18

Oh, and please rename the folders to be without the v4, e.g. drawable-hdpi instead of drawable-v4-hdpi. That could actually be it.
Ganna Kozynenko 2016-08-18

I was using my own module derived from 5.0.0, but resources were intact. It worked and it still works. But it has no drawable-XXX-v4 folders, those have appeared in 5.2.0 version only I did 2 kinds of experiments: - removed drawable-XXX-v4 - copied everything from drawable-XXX-v4 to drawable-XXX (which is already there) skipping duplicates In both cases it produced those second set of errors (maybe it was a slightly different set, I am not sure) So even if some pictures were indeed missing, there were more problems to it, it seems, than just dumping content of the folders into one another
Ganna Kozynenko 2016-08-18

There is no drawable-v4-hdpi, but drawable-hdpi-v4. I can't really RENAME them, because the drawable-hdpi already exists separately.
Hans Knöchel 2016-08-19

I just noticed that the pre-packaged Android 5.2.0 differs from the one available [here](https://github.com/appcelerator-modules/ti.facebook/releases/tag/android-5.2.0). Does that one work? It does not include the v4 in it.
Ashraf Abu 2016-08-22

It does seem that the packaged module is different from the release module. https://github.com/appcelerator-modules/ti.facebook/releases/tag/android-5.2.0 causes no compilation errors while the packaged module does. As Hans mentioned, [~annakozy@direcciona.me] Could you try that release version and see if it solves your issue?
Ashraf Abu 2016-08-22

PR https://github.com/appcelerator/titanium_mobile/pull/8246 Basically taking the 5.2.0 from the Release Page in github and replacing the one in Titanium Mobile SDK repo.
Hans Knöchel 2016-08-22

Fixed for 5.5.0, you can already download it from the ti.facebook/releases Tab which holds the correct module.
Ganna Kozynenko 2016-08-23

I checked with the release 5.2.0 for Android and yes, it compiles.
Eric Merriman 2018-08-06

Cleaning up older fixed issues. If this issue should not have been closed as fixed, please reopen.

JSON Source