Titanium JIRA Archive
Appcelerator Modules (MOD)

[MOD-2300] Ti.SafariDialog: tintColor does not work on iOS 9

GitHub Issuen/a
TypeBug
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2016-09-29T07:16:27.000+0000
Affected Version/sRelease 6.0.0
Fix Version/sRelease 6.0.0
ComponentsSafariDialog
LabelsiOS9, qe-6.0.0, safaridialog
ReporterHarry Bryant
AssigneeHans Knöchel
Created2016-09-28T13:08:55.000+0000
Updated2016-09-29T15:09:55.000+0000

Description

The fix made for MOD-2296 subsequently broke tintColor for iOS9. Switching the ti.safaridialog module version from 1.1.0 -> 1.0.5 resolves the issue.

TEST CODE:

var safari = require('ti.safaridialog');
 
var win = Ti.UI.createWindow({
    backgroundColor: 'white'
})

var btn = Ti.UI.createButton({
    title: "Open safari dialog"
});
 
btn.addEventListener("click", function() {
    safari.open({
        url:"http://google.com",
        title:"Hello World",
        tintColor:"red",
        //barColor:"red"
    });
});
 
safari.addEventListener("load", function(e) {
    var pageurl = e.url;
    var success = e.success;
    Ti.API.warn(pageurl + ' loaded with success value ' + success);
});
 
win.add(btn);
win.open();

Steps to Reproduce

1. Create a classic mobile application 2. Add ti.safaridialog (1.1.0) to project. 3. Use above test code in app.js 4. Launch app on iOS9 device / sim

Expected Result

"Done" Button and bottom toolbar icons should be Red.

Actual Result

"Done" Button and bottom toolbar icons remain as default. (blue)

Comments

  1. Hans Knöchel 2016-09-28

    PR: https://github.com/appcelerator-modules/ti.safaridialog/pull/10 PR (master): https://github.com/appcelerator/titanium_mobile/pull/8439 PR (6_0_X): https://github.com/appcelerator/titanium_mobile/pull/8440
  2. Chee Kiat Ng 2016-09-29

    [~hansknoechel] I think it'll be easier to track if we bump a patch version ie. 1.1.1. Sorry for the trouble.
  3. Hans Knöchel 2016-09-29

    PR's updated
  4. Harry Bryant 2016-09-29

    Verified as fixed, using safaridialog module (1.1.1) tintColor now works correctly on iOS9. Tested On: iPhone 5S 9.3.5 Device & Simulator Mac OSX El Capitan 10.11.6 Ti SDK: 6.0.0.v20160929031439 Appc Studio: 4.8.0.201609232005 Appc NPM: 4.2.8-7 App CLI: 6.0.0-54 Xcode 8.0 Node v4.4.7 *Closing ticket.*

JSON Source