[MOD-2537] ti.facebook: crash on iOS 13
| GitHub Issue | n/a |
|---|---|
| Type | New Feature |
| Priority | None |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2019-09-12T19:07:11.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 8.2.0 |
| Components | |
| Labels | n/a |
| Reporter | Hans Knöchel |
| Assignee | Vijay Singh |
| Created | 2019-09-11T14:57:27.000+0000 |
| Updated | 2019-09-17T18:02:06.000+0000 |
Description
The Facebook libs once again need to be updated, especially on iOS to support iOS 13+.
https://github.com/appcelerator-modules/ti.facebook/pull/103
Edit - This ticket include a part of fix from above PR to fix iOS 13 crash. For other changes we will go with MOD-2534
Attachments
| File | Date | Size |
|---|---|---|
| image1.png | 2019-09-13T03:46:43.000+0000 | 273996 |
https://github.com/appcelerator-modules/ti.facebook/pull/108
[~lchoudhary] can someone in QE please validate before closing?
Facebook has [login issue](https://github.com/facebook/facebook-objc-sdk/issues/1013) with iOS 13 and they fixed it in their SDK 5.4.1. If we use their latest SDK, they have removed FBSDKMessengerShareKit.framework (in 5.0.0). In our module we give functionality to create facebook [messenger button](https://docs.appcelerator.com/platform/latest/#!/api/Modules.Facebook.MessengerButton) which uses FBSDKMessengerShareKit.framework. So if we use latest Facebook SDK, we have to make breaking change. Solution is - Include FBSDKMessengerShareKit.framework from older Facebook SDK in our facebook module and give the facebook [messenger button](https://docs.appcelerator.com/platform/latest/#!/api/Modules.Facebook.MessengerButton) to developer. Remove it in major SDK release, 9.0.0. So I have created [PR-109](https://github.com/appcelerator-modules/ti.facebook/pull/109) base to https://github.com/appcelerator-modules/ti.facebook/pull/103, included FBSDKMessengerShareKit.framework and restored facebook messenger button functionality. cc [~cwilliams]
[~lchoudhary] Here's the PR that Vijay has put together with the updated Facebook libraries and the messenger button retained: https://github.com/appcelerator-modules/ti.facebook/pull/109 There are (very) basic unit tests around the messenger button that run but they basically just rove the API exists, not functionality. I think the concern here is to ensure that the messenger stuff still works with Vijay's changes and the new FB libraries. if not, then we'd probably be forced to take the breaking changes introduced by Han's original PR for MOD-2534
[~cwilliams] tested the example app in facebook module with the fix. facebook messenger did not work.on clicking messenger button throws “error :undefined and code :undefined” in device iOS 13 as well as lesser than that. Not getting any error in console. Also tried with older facebook module 6.0.0.same thing happened !image1.png|thumbnail!
Tested with the PR https://github.com/appcelerator-modules/ti.facebook/pull/103. login with facebook works fine on iOS 13
Verified the fix on sdk 8.2.0.v20190917100859. Facebook module works. able to login with facebook successfully .