[MOD-2545] Map: Add deselected parameter in click event
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2019-10-08T22:05:25.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 8.2.1 |
| Components | Map |
| Labels | n/a |
| Reporter | Christopher Williams |
| Assignee | Christopher Williams |
| Created | 2019-09-27T15:24:16.000+0000 |
| Updated | 2019-10-08T22:05:25.000+0000 |
Description
Since the click event will fire twice when you click a different annotation I've added a parameter to see if the source was deselected or not. Same for clicking on the map instead of a second annotation.
PR from Michael Gangolf: https://github.com/appcelerator-modules/ti.map/pull/271
https://github.com/appcelerator-modules/ti.map/pull/271
Moving back to Review, since we should add iOS parity. I've taken a stab at it, but need [~vijaysingh] to CR, then we can FR.
FR passed. The deselected parameter, with value true or false, added to click event.
PR to include in SDK 8.3.0: https://github.com/appcelerator/titanium_mobile/pull/11261
PR to include in SDK 8.2.x: https://github.com/appcelerator/titanium_mobile/pull/11266
Merged to master and 8_2_X
Verified On: Mac OS: 10.14.5 SDK: 8.2.1.v20191008121020, 8.3.0.v20191008081818 Appc CLI: 7.1.1 JDK: 1.8.0_162 Node: 10.5.0 Studio: 5.1.4.201909061933 Xcode: 11.0 iOS Device: iPhone X(13.0) Android Device: Nexus 4(v5.1.1), Pixel3 emulator(v10.0)