[MOD-2583] ti.crypto: Examples need to be updated

GitHub Issue	n/a
Type	Bug
Priority	None
Status	Closed
Resolution	Fixed
Resolution Date	2020-05-05T14:50:02.000+0000
Affected Version/s	Release 9.0.0
Fix Version/s	n/a
Components	n/a
Labels	2020-Q2
Reporter	Samir Mohammed
Assignee	Aakash Jain
Created	2020-02-11T11:49:01.000+0000
Updated	2020-05-05T14:50:02.000+0000

Description

ti.crypto includes ti.include which has now been removed in titanium and replaced with .require.

[ERROR] TiExceptionHandler: (main) [1540,1540] /app.js:23
[INFO]   I/ti.crypto.app: Waiting for a blocking GC ProfileSaver
[ERROR] TiExceptionHandler: Ti.include('ui.js');
[ERROR] TiExceptionHandler:    ^
[ERROR] TiExceptionHandler: TypeError: Ti.include is not a function
[ERROR] TiExceptionHandler:     at /app.js:23:4
[ERROR] TiExceptionHandler:     at Module._runScript (ti:/module.js:587:9)
[ERROR] TiExceptionHandler:     at Module.load (ti:/module.js:106:7)
[ERROR] TiExceptionHandler:     at Module.loadJavascriptText (ti:/module.js:436:9)
[ERROR] TiExceptionHandler:     at Module.loadAsFile (ti:/module.js:488:15)
[ERROR] TiExceptionHandler:     at Module.loadAsFileOrDirectory (ti:/module.js:410:20)
[ERROR] TiExceptionHandler:     at Module.require (ti:/module.js:239:23)

*+Test Steps:+*

Download module from (https://github.com/appcelerator-modules/ti.crypto/pull/11)

Build module

Copy the the code from the example

Paste the code into a Titanium application

Add module to app

Run Titanium application

*Expected result* Application should not crash and run without issues. *Actual result* Application throws above error *To be done:* Update the example code here... https://github.com/appcelerator-modules/ti.crypto/tree/master/android/example Or better yet, see if the iOS example code (link below can be used on Android. If so, then move iOS' example code folder to the module's root folder and delete the Android example folder. (It's always best to have cross-platform example code.) https://github.com/appcelerator-modules/ti.crypto/tree/master/ios/example

Comments

Samir Mohammed 2020-03-18

*NOTE:** iOS example will also need to be updated as it also uses ti.includes
Aakash Jain 2020-04-06

PR: https://github.com/appcelerator-modules/ti.crypto/pull/13
Aakash Jain 2020-04-17

[~jvennemann] : can you kindly review this PR: https://github.com/appcelerator-modules/ti.crypto/pull/13
Samir Mohammed 2020-05-01
Samir Mohammed 2020-05-01
Samir Mohammed 2020-05-05

*Closing ticket* Verified using the build from https://github.com/appcelerator-modules/ti.crypto/releases/tag/v5.0.0-android.

JSON Source