[MOD-2630] AdMob: Android & iOS parity (addressing Interstitial ad and BannerView)
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | None |
Status | In Review |
Resolution | Unresolved |
Affected Version/s | n/a |
Fix Version/s | n/a |
Components | Admob |
Labels | n/a |
Reporter | Aakash Jain |
Assignee | Aakash Jain |
Created | 2020-05-27T08:13:38.000+0000 |
Updated | 2020-06-22T07:08:47.000+0000 |
Description
In reference to the changes made in the iOS PR: https://github.com/appcelerator-modules/ti.admob/pull/86, the following change to be addressed in the Android:
- adding property isReady in the interstitialAd that exposes if the interstitial ad is ready to be shown or not.
- fix createBannerView crash in the android as observed in the [sample app](https://github.com/vikas-goyal-axway/ti.admob-sample) . The sample app is built on latest android module and the ios code using [PR](https://github.com/appcelerator-modules/ti.admob/pull/86)
PR: https://github.com/appcelerator-modules/ti.admob/pull/89