{
	"id": "155272",
	"key": "MOD-2203",
	"fields": {
		"issuetype": {
			"id": "4",
			"description": "An improvement or enhancement to an existing feature or task.",
			"name": "Improvement",
			"subtask": false
		},
		"project": {
			"id": "10034",
			"key": "MOD",
			"name": "Appcelerator Modules",
			"projectCategory": {
				"id": "10100",
				"description": "Titanium and related SDKs used in application development",
				"name": "Client"
			}
		},
		"fixVersions": [],
		"resolution": null,
		"resolutiondate": null,
		"created": "2016-03-02T10:17:19.000+0000",
		"priority": {
			"name": "Medium",
			"id": "3"
		},
		"labels": [],
		"versions": [
			{
				"id": "17157",
				"name": "Release 5.2.0",
				"archived": false,
				"released": true,
				"releaseDate": "2016-02-23"
			}
		],
		"issuelinks": [
			{
				"id": "50749",
				"type": {
					"id": "10120",
					"name": "Gantt: finish-start",
					"inward": "has to be done after",
					"outward": "has to be done before"
				},
				"inwardIssue": {
					"id": "155273",
					"key": "MOD-2204",
					"fields": {
						"summary": "Facebook: com.facebook.LoginActivity should be com.facebook.FacebookActivity",
						"status": {
							"description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.",
							"name": "Closed",
							"id": "6",
							"statusCategory": {
								"id": 3,
								"key": "done",
								"colorName": "green",
								"name": "Done"
							}
						},
						"priority": {
							"name": "High",
							"id": "2"
						},
						"issuetype": {
							"id": "1",
							"description": "A problem which impairs or prevents the functions of the product.",
							"name": "Bug",
							"subtask": false
						}
					}
				}
			},
			{
				"id": "50989",
				"type": {
					"id": "10003",
					"name": "Relates",
					"inward": "relates to",
					"outward": "relates to"
				},
				"outwardIssue": {
					"id": "155593",
					"key": "TIMOB-20542",
					"fields": {
						"summary": "Parity: iOS modules should be able to inject into tiapp.xml like Android modules",
						"status": {
							"description": "The issue is open and ready for the assignee to start work on it.",
							"name": "Open",
							"id": "1",
							"statusCategory": {
								"id": 2,
								"key": "new",
								"colorName": "blue-gray",
								"name": "To Do"
							}
						},
						"priority": {
							"name": "None",
							"id": "6"
						},
						"issuetype": {
							"id": "2",
							"description": "A new feature of the product, which has yet to be developed.",
							"name": "New Feature",
							"subtask": false
						}
					}
				}
			}
		],
		"assignee": null,
		"updated": "2018-03-06T18:52:39.000+0000",
		"status": {
			"description": "The issue is open and ready for the assignee to start work on it.",
			"name": "Open",
			"id": "1",
			"statusCategory": {
				"id": 2,
				"key": "new",
				"colorName": "blue-gray",
				"name": "To Do"
			}
		},
		"components": [
			{
				"id": "14521",
				"name": "Facebook"
			}
		],
		"description": "To use the Facebook module the user has to add a whole set of properties to {{tiapp.xml}}:\r\nhttp://docs.appcelerator.com/platform/latest/#!/api/Modules.Facebook\r\n\r\nHowever, except for maybe those that depend on the linked Facebook app (ID, name) all of this should be injected by the module itself using the {{timodule.xml}}.",
		"attachment": [],
		"flagged": false,
		"summary": "Facebook: Module should inject tiapp.xml requirements for user",
		"creator": {
			"name": "fokkezb",
			"key": "fokke",
			"displayName": "Fokke Zandbergen",
			"active": true,
			"timeZone": "Europe/Amsterdam"
		},
		"subtasks": [],
		"reporter": {
			"name": "fokkezb",
			"key": "fokke",
			"displayName": "Fokke Zandbergen",
			"active": true,
			"timeZone": "Europe/Amsterdam"
		},
		"environment": null,
		"comment": {
			"comments": [
				{
					"id": "378455",
					"author": {
						"name": "hknoechel",
						"key": "hansknoechel",
						"displayName": "Hans Knöchel",
						"active": true,
						"timeZone": "Europe/Berlin"
					},
					"body": "{quote}\r\nRight now, the timodule.xml is only used in Android, and it supports all of the tags listed in the Android section above. Any custom metadata your Android module defines in it's timodule.xml <android> section will automatically be merged with a Titanium application that installs your module.\r\n{quote}\r\n\r\nhttp://docs.appcelerator.com/platform/latest/#!/guide/tiapp.xml_and_timodule.xml_Reference-section-29004921_tiapp.xmlandtimodule.xmlReference-timodule.xml\r\n\r\nThat's why it's currently not implemented.",
					"updateAuthor": {
						"name": "hknoechel",
						"key": "hansknoechel",
						"displayName": "Hans Knöchel",
						"active": true,
						"timeZone": "Europe/Berlin"
					},
					"created": "2016-03-02T10:29:23.000+0000",
					"updated": "2016-03-02T10:29:23.000+0000"
				},
				{
					"id": "378458",
					"author": {
						"name": "fokkezb",
						"key": "fokke",
						"displayName": "Fokke Zandbergen",
						"active": true,
						"timeZone": "Europe/Amsterdam"
					},
					"body": "So for Android we could still do this right?",
					"updateAuthor": {
						"name": "fokkezb",
						"key": "fokke",
						"displayName": "Fokke Zandbergen",
						"active": true,
						"timeZone": "Europe/Amsterdam"
					},
					"created": "2016-03-02T10:40:55.000+0000",
					"updated": "2016-03-02T10:40:55.000+0000"
				},
				{
					"id": "378459",
					"author": {
						"name": "hknoechel",
						"key": "hansknoechel",
						"displayName": "Hans Knöchel",
						"active": true,
						"timeZone": "Europe/Berlin"
					},
					"body": "Yes, but there are no android-specific manifest settings required by ti.facebook as far as I know.",
					"updateAuthor": {
						"name": "hknoechel",
						"key": "hansknoechel",
						"displayName": "Hans Knöchel",
						"active": true,
						"timeZone": "Europe/Berlin"
					},
					"created": "2016-03-02T10:54:01.000+0000",
					"updated": "2016-03-02T10:54:01.000+0000"
				},
				{
					"id": "378461",
					"author": {
						"name": "fokkezb",
						"key": "fokke",
						"displayName": "Fokke Zandbergen",
						"active": true,
						"timeZone": "Europe/Amsterdam"
					},
					"body": "We do at http://docs.appcelerator.com/platform/latest/#!/api/Modules.Facebook :\r\n\r\n{code:xml}\r\n<ti:app>\r\n    <android xmlns:android=\"http://schemas.android.com/apk/res/android\">\r\n        <manifest>\r\n            <application>\r\n                <activity android:label=\"@string/app_name\"\r\n                    android:name=\"com.facebook.LoginActivity\" android:theme=\"@android:style/Theme.Translucent.NoTitleBar\"/>\r\n                <meta-data android:name=\"com.facebook.sdk.ApplicationId\" android:value=\"@string/facebook_app_id\"/>\r\n            </application>\r\n        </manifest>\r\n    </android>\r\n<ti:app>\r\n{code}",
					"updateAuthor": {
						"name": "fokkezb",
						"key": "fokke",
						"displayName": "Fokke Zandbergen",
						"active": true,
						"timeZone": "Europe/Amsterdam"
					},
					"created": "2016-03-02T11:37:32.000+0000",
					"updated": "2016-03-02T11:49:09.000+0000"
				},
				{
					"id": "378462",
					"author": {
						"name": "hknoechel",
						"key": "hansknoechel",
						"displayName": "Hans Knöchel",
						"active": true,
						"timeZone": "Europe/Berlin"
					},
					"body": "But those are user-specific values that we cannot pre-fill. :-) Tell me that exactly can be added and I'll add it. Simple as that.",
					"updateAuthor": {
						"name": "hknoechel",
						"key": "hansknoechel",
						"displayName": "Hans Knöchel",
						"active": true,
						"timeZone": "Europe/Berlin"
					},
					"created": "2016-03-02T11:42:20.000+0000",
					"updated": "2016-03-02T11:42:20.000+0000"
				},
				{
					"id": "378464",
					"author": {
						"name": "fokkezb",
						"key": "fokke",
						"displayName": "Fokke Zandbergen",
						"active": true,
						"timeZone": "Europe/Amsterdam"
					},
					"body": "They are not user-specific. The only user-specific thing is the value of {{@string/facebook_app_id}} which you set via {{strings.xml}}. See the linked doc.",
					"updateAuthor": {
						"name": "fokkezb",
						"key": "fokke",
						"displayName": "Fokke Zandbergen",
						"active": true,
						"timeZone": "Europe/Amsterdam"
					},
					"created": "2016-03-02T11:48:59.000+0000",
					"updated": "2016-03-02T11:48:59.000+0000"
				},
				{
					"id": "379327",
					"author": {
						"name": "hknoechel",
						"key": "hansknoechel",
						"displayName": "Hans Knöchel",
						"active": true,
						"timeZone": "Europe/Berlin"
					},
					"body": "PR: https://github.com/appcelerator-modules/ti.facebook/pull/44\r\n\r\nWe need to ensure the values get merged with the values set in the {{tiapp.xml}} correctly.",
					"updateAuthor": {
						"name": "hknoechel",
						"key": "hansknoechel",
						"displayName": "Hans Knöchel",
						"active": true,
						"timeZone": "Europe/Berlin"
					},
					"created": "2016-03-09T12:10:15.000+0000",
					"updated": "2016-03-09T12:10:15.000+0000"
				},
				{
					"id": "379330",
					"author": {
						"name": "fokkezb",
						"key": "fokke",
						"displayName": "Fokke Zandbergen",
						"active": true,
						"timeZone": "Europe/Amsterdam"
					},
					"body": "Well, there's one way to find out ;)",
					"updateAuthor": {
						"name": "fokkezb",
						"key": "fokke",
						"displayName": "Fokke Zandbergen",
						"active": true,
						"timeZone": "Europe/Amsterdam"
					},
					"created": "2016-03-09T12:18:48.000+0000",
					"updated": "2016-03-09T12:18:48.000+0000"
				},
				{
					"id": "379350",
					"author": {
						"name": "cbarber",
						"key": "cbarber",
						"displayName": "Chris Barber",
						"active": true,
						"timeZone": "America/Chicago"
					},
					"body": "As stated on Flowdock, the {{timodule.xml}} and {{tiapp.xml}} are not merged and nor will they ever be. Only in the Android builds will the {{timodule.xml}}'s {{<application><android><manifest>}} be scrubbed and merged with the final {{AndroidManifest.xml}}.\r\n\r\nI'm not sold that setting the {{@string/facebook_app_id}} via {{strings.xml}} is a good idea. First it's Android only. Second we should have all settings in one place, namely the {{tiapp.xml}}. Since this is a module, it must not modify the Titanium app. The module's documentation should be clear as to what settings the user must add to the {{tiapp.xml}}.",
					"updateAuthor": {
						"name": "cbarber",
						"key": "cbarber",
						"displayName": "Chris Barber",
						"active": true,
						"timeZone": "America/Chicago"
					},
					"created": "2016-03-09T16:16:49.000+0000",
					"updated": "2016-03-09T16:16:49.000+0000"
				},
				{
					"id": "379420",
					"author": {
						"name": "fokkezb",
						"key": "fokke",
						"displayName": "Fokke Zandbergen",
						"active": true,
						"timeZone": "Europe/Amsterdam"
					},
					"body": "[~cbarber] we actually do the same with modules like [ti.map|https://github.com/appcelerator-modules/ti.map/blob/master/android/timodule.xml] and it's much more user friendly (and less likely to give errors) then letting the user add those.\r\n\r\nI agree it shouldn't use string though. Just like the linked ti.map it should refer to a tiapp property.",
					"updateAuthor": {
						"name": "fokkezb",
						"key": "fokke",
						"displayName": "Fokke Zandbergen",
						"active": true,
						"timeZone": "Europe/Amsterdam"
					},
					"created": "2016-03-10T09:51:40.000+0000",
					"updated": "2016-03-10T09:51:40.000+0000"
				},
				{
					"id": "379421",
					"author": {
						"name": "fokkezb",
						"key": "fokke",
						"displayName": "Fokke Zandbergen",
						"active": true,
						"timeZone": "Europe/Amsterdam"
					},
					"body": "Plus.. iOS modules should be able to do the same: TIMOB-20542",
					"updateAuthor": {
						"name": "fokkezb",
						"key": "fokke",
						"displayName": "Fokke Zandbergen",
						"active": true,
						"timeZone": "Europe/Amsterdam"
					},
					"created": "2016-03-10T09:52:00.000+0000",
					"updated": "2016-03-10T09:55:23.000+0000"
				},
				{
					"id": "382900",
					"author": {
						"name": "hknoechel",
						"key": "hansknoechel",
						"displayName": "Hans Knöchel",
						"active": true,
						"timeZone": "Europe/Berlin"
					},
					"body": "Removing from review, since it's currently not technically possible to inject it properly.",
					"updateAuthor": {
						"name": "hknoechel",
						"key": "hansknoechel",
						"displayName": "Hans Knöchel",
						"active": true,
						"timeZone": "Europe/Berlin"
					},
					"created": "2016-04-17T12:02:18.000+0000",
					"updated": "2016-04-17T12:02:18.000+0000"
				}
			],
			"maxResults": 13,
			"total": 13,
			"startAt": 0
		}
	}
}