Titanium JIRA Archive
Appcelerator Modules (MOD)

[MOD-2272] TouchId Module: isSupported() return TRUE even for iPhone4S and iPhone 5 which doesn't have finger print sensor.

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2016-07-13T21:15:49.000+0000
Affected Version/sn/a
Fix Version/sRelease 6.0.0, Release 5.4.0
ComponentsTouchID
Labelsqe-5.4.0
ReporterShuo Liang
AssigneeAngel Petkov
Created2016-07-13T03:48:59.000+0000
Updated2016-07-26T17:47:07.000+0000

Description

isSupported() return TRUE even for iPhone4S and iPhone 5 which doesn't have finger print sensor.

Reproduce:

1.Add the example code into app.js. https://github.com/appcelerator-modules/ti.touchid/blob/master/ios/example/app.js 2. Run the app on 3 different devices.

Actual

isSupported() return TRUE even for iPhone4S and iPhone 5 which doesn't have finger print sensor.

Expect

isSupported() should return false for device doesn't have finger print sensor

Note

Customer tested iOS version 8 and above on iPhone 4S and iPhone 5

Comments

  1. Angel Petkov 2016-07-13

    Use demo-code from repo. PR:https://github.com/appcelerator-modules/ti.touchid/pull/20
  2. Hans Knöchel 2016-07-13

    Fixed, good job!
  3. Chee Kiat Ng 2016-07-13

    [~sliang] the fix is in 5.4.0.v20160713141635
  4. Hans Knöchel 2016-07-14

    Exactly. As discussed during review, if a device is not set-up for TouchID, it will return FALSE, because the check is context-based. *EDIT*: Also updated the [Releases tab](https://github.com/appcelerator-modules/ti.touchid/releases/tag/iOS-1.2.2) *EDIT2*: See [this video](https://youtu.be/uQs1HXYnFKY) for a demonstration. If the user has TouchID but didn't activate it, it is not supported *in the current app-context*. As soon as he activates it and calls the check again, it will return true.
  5. Harry Bryant 2016-07-26

    Verified as fixed, Here are the results from the following cases: *iPhone 4S:* returned FALSE. *iPhone 5S with FingerPrint Set:* returned TRUE. *iPhone 5S without FingerPrint Set:* returned FALSE. *iPhone 5:* returned FALSE. _Tested with iOS8._ Tested On: Mac OSX El Capitan 10.11.5 Ti SDK: 5.4.0.v20160725003348 Appc Studio: 4.7.0.201607111053 Appc NPM: 4.2.7 App CLI: 5.4.0-34 Xcode 7.3 Node v4.4.7 *Closing ticket.*

JSON Source