{ "id": "163073", "key": "MOD-2296", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10034", "key": "MOD", "name": "Appcelerator Modules", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "17524", "name": "Release 6.0.0", "archived": false, "released": true, "releaseDate": "2016-11-14" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2016-09-15T20:01:45.000+0000", "created": "2016-09-08T18:14:23.000+0000", "priority": { "name": "Critical", "id": "1" }, "labels": [ "qe-6.0.0" ], "versions": [ { "id": "17157", "name": "Release 5.2.0", "archived": false, "released": true, "releaseDate": "2016-02-23" } ], "issuelinks": [ { "id": "52817", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "163520", "key": "MOD-2300", "fields": { "summary": "Ti.SafariDialog: tintColor does not work on iOS 9", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } } ], "assignee": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "updated": "2016-09-28T13:12:00.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "14801", "name": "SafariDialog", "description": "ti.safaridialog" } ], "description": "The tint color we set for SafariDialog no longer seems to be affecting the ti.safaridialog module.\r\n\r\nI found this in the ios 10 release notes: http://adcdownload.apple.com/Documentation/Xcode_GM_seed_SDK_Release_Notes/iOS_10_GM_Seed_Release_Notes.pdf\r\n\r\n• The SFSafariViewControllerConfiguration and -[SFSafariViewController\r\ninitWithURL:configuration:] APIs have been removed, and -\r\n[SFSafariViewController initWithURL:entersReaderIfAvailable:] is no longer\r\nmarked as deprecated. The preferredBarTintColor property has been moved to\r\nSFSafariViewController, along with a new property preferredControlTintColor\r\nwhich clients should use instead of setting tintColor directly on the view. Apps linked on\r\niOS 10 or later will no longer forward their view's tint color to SFSafariViewController", "attachment": [ { "id": "60362", "filename": "screenshot-1.png", "author": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "created": "2016-09-28T12:41:59.000+0000", "size": 11596, "mimeType": "image/png" } ], "flagged": false, "summary": "iOS10: Ti.SafariDialog - tintColor on iOS 10 broken, new barColor property available", "creator": { "name": "cthomas", "key": "cthomas", "displayName": "Christy Thomas", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "cthomas", "key": "cthomas", "displayName": "Christy Thomas", "active": true, "timeZone": "America/Los_Angeles" }, "environment": "appcelerator 4.7\r\nti sdk 5.2.0", "closedSprints": [ { "id": 707, "state": "closed", "name": "2016 Sprint 19 SDK", "startDate": "2016-09-10T00:17:15.164Z", "endDate": "2016-09-24T00:17:00.000Z", "completeDate": "2016-09-26T05:17:04.253Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "395747", "author": { "name": "cthomas", "key": "cthomas", "displayName": "Christy Thomas", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Repo:\r\n\r\n{code}\r\n var safariDialog = require('ti.safaridialog');\r\n safariDialog.open({\r\n url : URL,\r\n entersReaderIfAvailable : false,\r\n // this doesn't work on iOS 10\r\n tintColor : '#d8d8d8'\r\n });\r\n{code}", "updateAuthor": { "name": "cthomas", "key": "cthomas", "displayName": "Christy Thomas", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2016-09-09T19:58:28.000+0000", "updated": "2016-09-09T19:59:12.000+0000" }, { "id": "395824", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "New API's to be exposed:\r\n- {{preferredControlTintColor}}: Used for {{tintColor}} in iOS 10\r\n- {{barTintColor}}: Exposed as a new API in iOS 10\r\n- {{load}} event: Available since iOS 9, but not exposed, yet\r\n\r\nThe changes are already implemented, but the PR needs to be shifted due to priority for fixing more critical iOS 10 issues first. Thanks!\r\n\r\n*EDIT*: Changed the fix-version to 6.0.0, but the module itself will be available next week already. This fix-version is just used for determinating the prepackaged version of the module.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-09-11T11:31:45.000+0000", "updated": "2016-09-11T14:10:52.000+0000" }, { "id": "395828", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "PR: https://github.com/appcelerator-modules/ti.safaridialog/pull/9\r\nPR (titanium_mobile/master): https://github.com/appcelerator/titanium_mobile/pull/8344\r\nPR (titanium_mobile(6_0_X): https://github.com/appcelerator/titanium_mobile/pull/8345", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-09-11T13:58:34.000+0000", "updated": "2016-09-11T16:56:25.000+0000" }, { "id": "395840", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "6,0,0 backport is fine.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-09-11T16:45:43.000+0000", "updated": "2016-09-11T16:45:43.000+0000" }, { "id": "396251", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "h4. Steps to test\r\n1. *appc new --classic*\r\n2. add ti.safaridialog module in tiapp.xml\r\n3. use this sample code\r\n{code}\r\nvar safari = require('ti.safaridialog');\r\n\r\nvar win = Ti.UI.createWindow({\r\n backgroundColor: 'white'\r\n})\r\n\r\nvar btn = Ti.UI.createButton({\r\n title: \"Open safari dialog\"\r\n});\r\n\r\nbtn.addEventListener(\"click\", function() {\r\n safari.open({\r\n url:\"http://google.com\",\r\n title:\"Hello World\",\r\n tintColor:\"blue\",\r\n barColor:\"red\"\r\n });\r\n});\r\n\r\nsafari.addEventListener(\"load\", function(e) {\r\n var pageurl = e.url;\r\n var success = e.success;\r\n Ti.API.warn(pageurl + ' loaded with success value ' + success);\r\n});\r\n\r\nwin.add(btn);\r\nwin.open();\r\n\r\n{code}\r\n4. *appc run -p ios*\r\n5. Click button\r\n\r\nh4. Expected result\r\nSafari Dialog shows with a red bar and a blue tint. and after webpage is loaded, you will see some information on console.\r\n", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-09-15T19:57:59.000+0000", "updated": "2016-09-15T19:57:59.000+0000" }, { "id": "396252", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "CR and FT passed. APPROVED. PRs merged.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-09-15T20:01:10.000+0000", "updated": "2016-09-15T20:01:10.000+0000" }, { "id": "397502", "author": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "body": "the new barColor property works as expected with iOS10, as well as tintColor with the latest ti.safaridialog module (1.1.0). However tintColor no longer works with iOS9, and a simple revert to ti.safaridialog (1.0.5) fixes that. Please see the matrix below:\r\n\r\n!screenshot-1.png!\r\n\r\nAs the matrix shows that tintColor and the new barColor property for iOS10 have been implemented correctly, the ticket has been satisfied. *Closing* this ticket and created a new one in regards to iOS9: MOD-2300\r\n\r\nTested On:\r\niPhone 6 Plus 10.0.1 Device\r\niPhone 5S 9.3.5 Device & Simulator\r\nMac OSX El Capitan 10.11.6\r\nTi SDK: 6.0.0.v20160927221257\r\nAppc Studio: 4.8.0.201609232005\r\nAppc NPM: 4.2.8-7\r\nApp CLI: 6.0.0-54\r\nXcode 8.0 \r\nNode v4.4.7\r\n", "updateAuthor": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "created": "2016-09-28T13:10:38.000+0000", "updated": "2016-09-28T13:10:38.000+0000" } ], "maxResults": 7, "total": 7, "startAt": 0 } } }