{ "id": "163237", "key": "MOD-2298", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10034", "key": "MOD", "name": "Appcelerator Modules", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "18336", "name": "Release 5.5.1", "archived": false, "released": true }, { "id": "18337", "name": "facebook 5.2.7", "archived": false, "released": true } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2016-09-17T11:49:49.000+0000", "created": "2016-09-15T21:08:41.000+0000", "priority": { "name": "Critical", "id": "1" }, "labels": [], "versions": [], "issuelinks": [], "assignee": null, "updated": "2020-01-13T19:58:30.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "14521", "name": "Facebook" } ], "description": "During the release for 5.5.0, the docs was not updated for Facebook because the yaml file new entry was not done correctly. This should be fixed so that in the future release, this won't be broken again.", "attachment": [], "flagged": false, "summary": "Ti.Facebook: Unformatted iOS 10 / 5.5.0 example causes publish-process to break ", "creator": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "environment": null, "closedSprints": [ { "id": 722, "state": "closed", "name": "2016 Sprint 20 SDK", "startDate": "2016-09-28T16:50:17.299Z", "endDate": "2016-10-12T16:50:00.000Z", "completeDate": "2016-10-10T06:17:01.016Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "396274", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "[~bimmel] can you indicate what you changed on the yaml file here please.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-09-15T21:09:05.000+0000", "updated": "2016-09-15T21:09:05.000+0000" }, { "id": "396290", "author": { "name": "bimmel-defective", "key": "bimmel", "displayName": "(deactived) Brian Immel", "active": false, "timeZone": "America/Los_Angeles" }, "body": "From the https://github.com/appcelerator-modules/ti.facebook/blob/0ed96e476fce3f55ba53cd1eecee7a906a0868ef/apidoc/Facebook.yml#L17 commit, the \"Using Facebook module with iOS 10 and Xcode 8\" announcement looked like this:\r\n{code}\r\n **Using Facebook module with iOS 10 and Xcode 8**\r\n To log in using facebook, we now have to include an entitlements file that enables Keychain Sharing\r\n Capabilities. To do so, create a `/platform/ios/.entitlements` file with this content\r\n \r\n \r\n \r\n \r\n \tkeychain-access-groups\r\n \t\r\n \r\n APP_ID\r\n \t\r\n \r\n \r\n{code}\r\n\r\nand with my changes (https://github.com/appcelerator-modules/ti.facebook/blob/182d35ac63ed01ec713770220bf8ad6c87a6eba3/apidoc/Facebook.yml#L17):\r\n{code}\r\n **Using Facebook module with iOS 10 and Xcode 8**\r\n To log in using Facebook, we now have to include an entitlements file that enables Keychain Sharing\r\n Capabilities. To do so, create a `/platform/ios/.entitlements` file with this content\r\n \r\n \r\n \r\n \r\n \tkeychain-access-groups\r\n \t\r\n \r\n $(AppIdentifierPrefix)APP_ID\r\n \t\r\n \r\n \r\n{code}\r\n\r\nTL;DR: The code sample needed to be indented to a different level from the content above it. Otherwise, the APIdoc generator will treat all content as text but in this case, since the code sample has HTML tags in it, the generator attempted to pass the tags as part of the page.", "updateAuthor": { "name": "bimmel-defective", "key": "bimmel", "displayName": "(deactived) Brian Immel", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-09-15T21:38:45.000+0000", "updated": "2016-09-15T21:38:45.000+0000" }, { "id": "396346", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Yes, makes sense. I don't know why it broke the generation, since I would expect that it is \"just\" unformatted. [~bimmel] Can you do a PR for that and push the apidocs after merging?", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-09-16T14:52:47.000+0000", "updated": "2016-09-16T14:52:47.000+0000" }, { "id": "396356", "author": { "name": "bimmel-defective", "key": "bimmel", "displayName": "(deactived) Brian Immel", "active": false, "timeZone": "America/Los_Angeles" }, "body": "[~hans123], the changes have already been pushed up and the API docs published.", "updateAuthor": { "name": "bimmel-defective", "key": "bimmel", "displayName": "(deactived) Brian Immel", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-09-16T16:18:26.000+0000", "updated": "2016-09-16T16:18:26.000+0000" }, { "id": "396377", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "PR here. https://github.com/appcelerator-modules/ti.facebook/pull/68", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-09-16T20:43:00.000+0000", "updated": "2016-09-16T23:46:21.000+0000" }, { "id": "440135", "author": { "name": "emerriman", "key": "emerriman", "displayName": "Eric Merriman ", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Cleaning up older fixed issues. If this issue should not have been closed as fixed, please reopen.", "updateAuthor": { "name": "emerriman", "key": "emerriman", "displayName": "Eric Merriman ", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-08-06T17:49:22.000+0000", "updated": "2018-08-06T17:49:22.000+0000" } ], "maxResults": 6, "total": 6, "startAt": 0 } } }