Titanium

[MOD-2310] iOS: Update Facebook SDK in Ti.Facebook to fix FBSDKLoginManager issues

GitHub Issuen/a
TypeStory
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2016-11-01T03:16:39.000+0000
Affected Version/sn/a
Fix Version/sRelease 6.0.0
ComponentsFacebook
Labelsn/a
ReporterHans Knöchel
AssigneeHans Knöchel
Created2016-10-30T23:09:49.000+0000
Updated2018-08-06T17:49:12.000+0000

Description

Facebook released the version 4.17.0 of their iOS SDK last week, fixing some major issues in FBSDKLoginManager that our users also experienced: - Fixed potential issues when presenting UI without a dispatch in the FBSDKLoginManager callbacks. - Fixed bug where FBSDKLoginManager was prematurely deallocated. I would like to update the SDK, bump to version by one patch version and include that for the 6.0.0.GA - without any new features. That would result in 4 PR's: - ti.facebook (master): Bump from 5.3.0 to 5.3.1 - ti.facebook (5_2_X): Bump from 5.2.7 to 5.2.8 - titanium_mobile (master): Update prepackaged version to 5.3.1 - titanium_mobile (6_0_X): Update prepackaged version to 5.2.8 Can we do that?

Comments

  1. Hans Knöchel 2016-10-30 PR's (to be discussed): - ti.facebook (master): https://github.com/appcelerator-modules/ti.facebook/pull/73 - ti.facebook (5_2_X): https://github.com/appcelerator-modules/ti.facebook/pull/74 - titanium_mobile (master): https://github.com/appcelerator/titanium_mobile/pull/8566 - titanium_mobile (6_0_X): https://github.com/appcelerator/titanium_mobile/pull/8567
  2. Eric Merriman 2018-08-06 Cleaning up older fixed issues. If this issue should not have been closed as fixed, please reopen.

JSON Source