[MOD-2333] Make basic image filters like brightness, contrast, sepia, etc. as a part image factory module for iOS and Android
| GitHub Issue | n/a |
|---|---|
| Type | New Feature |
| Priority | Low |
| Status | Resolved |
| Resolution | Done |
| Resolution Date | 2017-04-26T14:46:57.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | n/a |
| Components | ImageFactory |
| Labels | android, filters, image, ios, module |
| Reporter | Zarir Bhesania |
| Assignee | John V Pataki |
| Created | 2017-04-25T07:00:13.000+0000 |
| Updated | 2017-04-26T14:47:03.000+0000 |
Description
Can we have basic image filters like brightness, contrast, sepia, etc. integrated into the existing image factory module for iOS and Android? This would really be helpful to a lot of developers as I have seen from the google search results that a lot of people had looked out for something similar but there was no concrete module available.
There are a couple of modules on marketplace but unfortunately they are only iOS based. We can have one module for all the functionality related to images.
Thanks for the request. Our engineering team will consider it.
There is an iOS module to support the
GPUImagelibrary on iOS [here](https://github.com/hansemannn/titanium-image-filters), feel free to do the Android equivalent as well! It will probably stay an own library, since ti.imagefactory is currently more focussed on image manipulation (cropping, sizing) rather than filtering.@Hans Knöchel Thanks for the iOS module. Can you please explain how to change brightness by sending values (0.0-1.0) to the module?
You can use the
GPUImageBrightnessFilterfilter, but filter values are not supported in the module so far. Feel free to change the module to do so. *EDIT*: I just added that functionality as well. You can now usecreateFilterto create a new filter and supply the desired properties like natively. Please just read the native docs carefully, it includes everything you might need.