{ "id": "174114", "key": "MOD-2538", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10034", "key": "MOD", "name": "Appcelerator Modules", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2019-09-20T21:58:21.000+0000", "created": "2019-09-10T16:51:10.000+0000", "priority": { "name": "None", "id": "6" }, "labels": [ "engSchedule", "iOS13" ], "versions": [ { "id": "20887", "name": "Release 8.2.0", "archived": false, "released": false } ], "issuelinks": [], "assignee": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2019-09-21T06:41:32.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [], "description": "Having a problem with iOS 13 and the Admob Module. With iOS 13 it opens interstitial ads in the new modal style window so you can see the app behind it. I do not think it should be like this.", "attachment": [], "flagged": false, "summary": "iOS 13: Interstitial ads are opened in the new modal style window with Admob Module", "creator": { "name": "amukherjee", "key": "amukherjee", "displayName": "Abir Mukherjee", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "amukherjee", "key": "amukherjee", "displayName": "Abir Mukherjee", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "closedSprints": [ { "id": 1163, "state": "closed", "name": "2019 Sprint 19", "startDate": "2019-09-09T20:43:13.091Z", "endDate": "2019-09-22T20:43:00.000Z", "completeDate": "2019-09-23T15:37:35.874Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "451272", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Google needs to fix their Admob SDK, this is not a Titanium issue.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2019-09-10T19:08:11.000+0000", "updated": "2019-09-10T19:08:11.000+0000" }, { "id": "451274", "author": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~amukherjee] Hans is right. We are calling their API to present view controller from [here|https://github.com/appcelerator-modules/ti.admob/blob/5f696a71e1766fe086b254f04edf11e3a06fe13d/ios/Classes/TiAdmobView.m#L225]. \r\nProbably In latest Admob SDK, it may have been fixed. I'll check.", "updateAuthor": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-10T19:35:21.000+0000", "updated": "2019-09-10T19:35:21.000+0000" }, { "id": "451279", "author": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "body": "I have not tested with Admob SDK 7.49.0 to see if it was fixed. I have not had the time to update a module with it. But I did report the issue to Google, will update if they respond. ", "updateAuthor": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-11T00:13:40.000+0000", "updated": "2019-09-11T00:13:40.000+0000" }, { "id": "451280", "author": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "body": "I just verified it. It is fixed in 7.49.0. Will create PR.", "updateAuthor": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-11T00:15:54.000+0000", "updated": "2019-09-11T00:15:54.000+0000" }, { "id": "451281", "author": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Ah awesome, thanks Vijay :D", "updateAuthor": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-11T00:16:56.000+0000", "updated": "2019-09-11T00:16:56.000+0000" }, { "id": "451282", "author": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "body": "PR - https://github.com/appcelerator-modules/ti.admob/pull/91", "updateAuthor": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-11T00:27:24.000+0000", "updated": "2019-09-11T00:27:24.000+0000" }, { "id": "451521", "author": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Any update on if this PR has been merged now that iOS 13 is officially out now?", "updateAuthor": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-20T02:45:59.000+0000", "updated": "2019-09-20T02:45:59.000+0000" }, { "id": "451524", "author": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Yeah. It’s merged. You can get updated module from https://github.com/appcelerator-modules/ti.admob/releases . ", "updateAuthor": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-20T04:22:57.000+0000", "updated": "2019-09-20T04:22:57.000+0000" }, { "id": "451531", "author": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Thank you Vijay. I see the module folder is now 150 MB+ in size is that normal?", "updateAuthor": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-20T16:09:08.000+0000", "updated": "2019-09-20T16:09:08.000+0000" }, { "id": "451540", "author": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Yeah. It's normal. You can see the major size of this folder comes due to frameworks inside platform/ folder. ", "updateAuthor": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-20T19:04:06.000+0000", "updated": "2019-09-20T19:04:06.000+0000" }, { "id": "451545", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "FR Passed.\r\nPR Merged.\r\nClosing.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-20T21:58:14.000+0000", "updated": "2019-09-20T21:58:14.000+0000" }, { "id": "451549", "author": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "body": "This module does not seem to work or has some issue. It crashes every time I open the simulator with the module. Even with the example provided. \r\n\r\nI'm using 8.2.0 GA SDK. ", "updateAuthor": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-21T05:43:09.000+0000", "updated": "2019-09-21T05:43:09.000+0000" }, { "id": "451550", "author": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "body": "After running some more tests I finally got the app to not crash on start up but I get the following error. It still does not work. \r\n\r\n\r\n{code:java}\r\n[ERROR] : Script Error {\r\n[ERROR] : column = 9;\r\n[ERROR] : line = 60;\r\n[ERROR] : message = \"The Google Mobile Ads SDK was initialized incorrectly. Google AdMob publishers, follow instructions here: https://googlemobileadssdk.page.link/admob-ios-update-plist to include the AppMeasurement framework, set the -ObjC linker flag, and set GADApplicationIdentifier with a valid App ID. Google Ad Manager publishers, follow instructions here: https://googlemobileadssdk.page.link/ad-manager-ios-update-plist\";\r\n[ERROR] : nativeStack = \"3 iPadTest 0x000000010bba7834 GADApplicationVerifyPublisherInitializedAnalyticsCorrectly + 263\\n4 iPadTest 0x000000010bb573c8 GADStatusBarOrientation + 3141\\n5 iPadTest 0x000000010bb57765 GADStatusBarOrientation + 4066\\n6 iPadTest 0x000000010bb5e527 GADDispatchAsyncSafeMainQueue + 45\\n7 iPadTest 0x000000010bb5773b GADStatusBarOrientation + 4024\\n8 iPadTest 0x000000010bbb3d48 GAD_GADAdSource_x86_64_7_49_0 + 2093\\n9 iPadTest 0x000000010bb75fd3 GAD_GADInternalBannerView_x86_64_7_49_0 + 8013\\n10 iPadTest 0x000000010bb75449 GAD_GADInternalBannerView_x86_64_7_49_0 + 5059\\n11 iPadTest 0x000000010bb5e527 GADDispatchAsyncSafeMainQueue + 45\\n12 iPadTest 0x000000010bb751d2 GAD_GADInternalBannerView_x86_64_7_49_0 + 4428\\n13 iPadTest 0x000000010bb75618 GAD_GADInternalBannerView_x86_64_7_49_0 + 5522\\n14 iPadTest 0x000000010bb21c77 GAD_GADBannerView_x86_64_7_49_0 + 4535\\n15 iPadTest 0x000000010bd0b7ab -[TiAdmobView frameSizeChanged:bounds:] + 386\\n16 TitaniumKit0x000000010c51a655 -[TiUIView checkBounds] + 506\\n17 TitaniumKit0x000000010c51a6bb -[TiUIView setBounds:] + 83\\n18 TitaniumKit0x000000010c52e8d2 -[TiViewProxy relayout] + 842\\n19 TitaniumKit0x000000010c52ae11 -[TiViewProxy view] + 795\\n20 TitaniumKit0x000000010c52acc9 -[TiViewProxy view] + 467\\n21 TitaniumKit0x000000010c4fe7d2 -[TiWindowProxy openOnUIThread:] + 72\\n22 TitaniumKit0x000000010c4fd87e -[TiWindowProxy open:] + 988\";\r\n[ERROR] : sourceURL = \"file:///Users/Name/Library/Developer/CoreSimulator/Devices/46400291-97B0-4D95-A380-EB5638FCC2BF/data/Containers/Bundle/Application/9091A184-87B8-4E61-A29D-B95731D349A6/iPadTest.app/app.js\";\r\n[ERROR] : stack = \" at [native code]\\n at (/app.js:60:9)\\n at global code(/app.js:63:70)\\n at require@[native code]\\n at (/ti.main.js:11677:10)\\n at loadAsync(/ti.main.js:11603:13)\\n at global code(/ti.main.js:11674:10)\";\r\n[ERROR] : toJSON = \"\";\r\n[ERROR] : }\r\n{code}\r\n\r\n\r\n\r\n{code:java}\r\n[ERROR] : Script Error {\r\n[ERROR] : column = 10;\r\n[ERROR] : line = 11677;\r\n[ERROR] : message = \"-[__NSCFString count]: unrecognized selector sent to instance 0x7f914a09b000\";\r\n[ERROR] : sourceURL = \"file:///Users/name/Library/Developer/CoreSimulator/Devices/46400291-97B0-4D95-A380-EB5638FCC2BF/data/Containers/Bundle/Application/9091A184-87B8-4E61-A29D-B95731D349A6/iPadTest.app/ti.main.js\";\r\n[ERROR] : stack = \" at require@[native code]\\n at (/ti.main.js:11677:10)\\n at loadAsync(/ti.main.js:11603:13)\\n at global code(/ti.main.js:11674:10)\";\r\n[ERROR] : toJSON = \"\";\r\n[ERROR] : }\r\n{code}\r\n", "updateAuthor": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-21T06:21:36.000+0000", "updated": "2019-09-21T06:21:36.000+0000" }, { "id": "451551", "author": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "body": "See the doc. “ If using module 2.5.0+, add following key in tiapp.xml, inside ios plist section. \n\t GADIsAdManagerApp\n\t \nProbably it will fix your problem.", "updateAuthor": { "name": "vijaysingh", "key": "vijaysingh", "displayName": "Vijay Singh", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-21T06:36:39.000+0000", "updated": "2019-09-21T06:36:39.000+0000" }, { "id": "451552", "author": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Thanks for letting me know about that. I still get tho with 2.5.0 of the module now.\r\n\r\n{code:java}\r\n[ERROR] ** BUILD FAILED **\r\n[ERROR] The following build commands failed:\r\n[ERROR] Ld /Users/name/Documents/Workspace/iPad\\ Test/build/iphone/build/Products/Debug-iphonesimulator/iPadTest.app/iPadTest normal x86_64\r\n[ERROR] (1 failure)\r\n{code}\r\n\r\nBut doesn't tell me anything more.", "updateAuthor": { "name": "dlewis23", "key": "dlewis23", "displayName": "Donovan Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-09-21T06:41:32.000+0000", "updated": "2019-09-21T06:41:32.000+0000" } ], "maxResults": 17, "total": 17, "startAt": 0 } } }