Titanium JIRA Archive
Appcelerator Modules (MOD)

[MOD-2545] Map: Add deselected parameter in click event

GitHub Issuen/a
TypeImprovement
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2019-10-08T22:05:25.000+0000
Affected Version/sn/a
Fix Version/sRelease 8.2.1
ComponentsMap
Labelsn/a
ReporterChristopher Williams
AssigneeChristopher Williams
Created2019-09-27T15:24:16.000+0000
Updated2019-10-08T22:05:25.000+0000

Description

Since the click event will fire twice when you click a different annotation I've added a parameter to see if the source was deselected or not. Same for clicking on the map instead of a second annotation. PR from Michael Gangolf: https://github.com/appcelerator-modules/ti.map/pull/271

Comments

  1. Christopher Williams 2019-09-27

    https://github.com/appcelerator-modules/ti.map/pull/271
  2. Christopher Williams 2019-10-02

    Moving back to Review, since we should add iOS parity. I've taken a stab at it, but need [~vijaysingh] to CR, then we can FR.
  3. Satyam Sekhri 2019-10-02

    FR passed. The deselected parameter, with value true or false, added to click event.
  4. Christopher Williams 2019-10-03

    PR to include in SDK 8.3.0: https://github.com/appcelerator/titanium_mobile/pull/11261
  5. Satyam Sekhri 2019-10-07

    PR to include in SDK 8.2.x: https://github.com/appcelerator/titanium_mobile/pull/11266
  6. Christopher Williams 2019-10-08

    Merged to master and 8_2_X
  7. Satyam Sekhri 2019-10-08

    Verified On: Mac OS: 10.14.5 SDK: 8.2.1.v20191008121020, 8.3.0.v20191008081818 Appc CLI: 7.1.1 JDK: 1.8.0_162 Node: 10.5.0 Studio: 5.1.4.201909061933 Xcode: 11.0 iOS Device: iPhone X(13.0) Android Device: Nexus 4(v5.1.1), Pixel3 emulator(v10.0)

JSON Source