{ "id": "174828", "key": "MOD-2588", "fields": { "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false }, "project": { "id": "10034", "key": "MOD", "name": "Appcelerator Modules", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "21022", "name": "Release 9.1.0", "archived": false, "released": false } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2020-07-27T17:52:10.000+0000", "created": "2020-03-18T16:42:09.000+0000", "priority": { "name": "High", "id": "2" }, "labels": [ "2020-Q3", "android", "module", "passcode", "password", "ti.identity" ], "versions": [], "issuelinks": [ { "id": "58273", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "172890", "key": "MOD-2489", "fields": { "summary": "iOS: Passcode Authentication feature on ti.identity module ", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false } } } } ], "assignee": { "name": "amaheshwari", "key": "amaheshwari", "displayName": "Akansha Maheshwari", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2020-07-27T17:52:10.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "15701", "name": "Identity", "description": "Deprecated the old “TouchId” component " } ], "description": "*Summary:*\r\nThe \"ti.identity\" module for Android should fallback to using the device's password, pin, or touch-pattern if a biometric means of identification (ie: touch id or face id) is not available.\r\n\r\n*To-Do:*\r\nWhen setting up the Java {{BiometricPrompt.PromptInfo.Builder}}, we should call the {{setDeviceCredentialAllowed()}} and to {{true}} to enable fallback support... but only\r\nhttps://developer.android.com/training/sign-in/biometric-auth#allow-fallback\r\n\r\nWe should only set it to {{true}} if the module's {{AUTHENTICATION_POLICY_PASSCODE}} is set. This is for parity with iOS.\r\n\r\nCurrently, we prompt in the following 2 places in the code...\r\n[FingerPrintHelper.java#L127|https://github.com/appcelerator-modules/titanium-identity/blob/3e0d849bf6e157df60b48efd272857fa4c3e8b4f/android/src/ti/identity/FingerPrintHelper.java#L127]\r\n[KeychainItemProxy.java#L159|https://github.com/appcelerator-modules/titanium-identity/blob/3e0d849bf6e157df60b48efd272857fa4c3e8b4f/android/src/ti/identity/KeychainItemProxy.java#L159]\r\n", "attachment": [], "flagged": false, "summary": "Android: Add fallback support to password, pin, or touch-pattern in \"ti.identity\"", "creator": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "closedSprints": [ { "id": 1201, "state": "closed", "name": "2020 Sprint 14", "startDate": "2020-07-06T15:40:00.000Z", "endDate": "2020-07-17T15:40:00.000Z", "completeDate": "2020-07-20T22:16:28.367Z", "originBoardId": 114 }, { "id": 1202, "state": "closed", "name": "2020 Sprint 15", "startDate": "2020-07-20T22:16:05.601Z", "endDate": "2020-07-31T22:16:00.000Z", "completeDate": "2020-08-03T20:27:12.585Z", "originBoardId": 114 }, { "id": 1195, "state": "closed", "name": "2020 Sprint 10", "startDate": "2020-05-08T16:37:58.282Z", "endDate": "2020-05-22T16:37:00.000Z", "completeDate": "2020-05-21T15:26:11.089Z", "originBoardId": 114 }, { "id": 1196, "state": "closed", "name": "2020 Sprint 11", "startDate": "2020-05-26T15:56:00.000Z", "endDate": "2020-06-05T15:56:00.000Z", "completeDate": "2020-06-08T21:05:50.356Z", "originBoardId": 114 }, { "id": 1198, "state": "closed", "name": "2020 Sprint 12", "startDate": "2020-06-08T21:06:41.849Z", "endDate": "2020-06-19T21:06:00.000Z", "completeDate": "2020-06-19T15:54:38.493Z", "originBoardId": 114 }, { "id": 1199, "state": "closed", "name": "2020 Sprint 13", "startDate": "2020-06-19T16:41:04.099Z", "endDate": "2020-07-02T16:41:00.000Z", "completeDate": "2020-07-02T15:37:12.455Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "455200", "author": { "name": "amaheshwari", "key": "amaheshwari", "displayName": "Akansha Maheshwari", "active": true, "timeZone": "America/Los_Angeles" }, "body": "https://github.com/appcelerator-modules/titanium-identity/pull/52\r\n\r\nIn this, i add the fallback for the device's when the biometric means of identification is not available in the Module's TiIdentity.authenticate method.", "updateAuthor": { "name": "amaheshwari", "key": "amaheshwari", "displayName": "Akansha Maheshwari", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-04-21T14:44:27.000+0000", "updated": "2020-04-21T14:44:27.000+0000" }, { "id": "456242", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~jquick], This will need a module ver update to 3.0.2 in the SDK repo as well as this is included with the SDK.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-07-27T15:58:57.000+0000", "updated": "2020-07-27T15:58:57.000+0000" }, { "id": "456244", "author": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "body": "merged PR including it in SDK to master. Cherry-picked to 9_1_X and 9_3_X branches.", "updateAuthor": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "created": "2020-07-27T17:44:38.000+0000", "updated": "2020-07-27T17:44:38.000+0000" }, { "id": "456245", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified module have been added to SDK branches.\r\nClosing.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-07-27T17:52:01.000+0000", "updated": "2020-07-27T17:52:01.000+0000" } ], "maxResults": 4, "total": 4, "startAt": 0 } } }