{ "id": "175185", "key": "MOD-2654", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10034", "key": "MOD", "name": "Appcelerator Modules", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [], "resolution": null, "resolutiondate": null, "created": "2020-06-25T09:52:04.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "android" ], "versions": [], "issuelinks": [], "assignee": { "name": "aajain", "key": "aajain", "displayName": "Aakash Jain", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2021-01-15T17:50:53.000+0000", "status": { "description": "The issue is open and ready for the assignee to start work on it.", "name": "Open", "id": "1", "statusCategory": { "id": 2, "key": "new", "colorName": "blue-gray", "name": "To Do" } }, "components": [ { "id": "15907", "name": "Web Dialog" } ], "description": "In the webdialog module currently a developer can detect the closing of a webdialog using the {{close}} event. Currently Android has no equivalent for this event currently, however it is possible to support this\r\n\r\nCommunity PR: https://github.com/appcelerator-modules/titanium-web-dialog/pull/19", "attachment": [], "flagged": false, "summary": "WebDialog: Support close event on Android", "creator": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "subtasks": [], "reporter": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "environment": null, "closedSprints": [ { "id": 1201, "state": "closed", "name": "2020 Sprint 14", "startDate": "2020-07-06T15:40:00.000Z", "endDate": "2020-07-17T15:40:00.000Z", "completeDate": "2020-07-20T22:16:28.367Z", "originBoardId": 114 }, { "id": 1202, "state": "closed", "name": "2020 Sprint 15", "startDate": "2020-07-20T22:16:05.601Z", "endDate": "2020-07-31T22:16:00.000Z", "completeDate": "2020-08-03T20:27:12.585Z", "originBoardId": 114 }, { "id": 1203, "state": "closed", "name": "2020 Sprint 16", "startDate": "2020-08-03T20:57:55.114Z", "endDate": "2020-08-14T20:57:00.000Z", "completeDate": "2020-08-14T15:19:51.647Z", "originBoardId": 114 }, { "id": 1204, "state": "closed", "name": "2020 Sprint 17", "startDate": "2020-08-17T15:48:00.000Z", "endDate": "2020-08-28T15:48:00.000Z", "completeDate": "2020-08-31T15:36:28.040Z", "originBoardId": 114 }, { "id": 1205, "state": "closed", "name": "2020 Sprint 18", "startDate": "2020-08-31T15:45:10.220Z", "endDate": "2020-09-11T15:45:00.000Z", "completeDate": "2020-09-11T19:56:20.674Z", "originBoardId": 114 }, { "id": 1206, "state": "closed", "name": "2020 Sprint 19", "startDate": "2020-09-14T20:01:00.000Z", "endDate": "2020-09-25T20:01:00.000Z", "completeDate": "2020-09-28T15:30:19.875Z", "originBoardId": 114 }, { "id": 1207, "state": "closed", "name": "2020 Sprint 20", "startDate": "2020-09-28T15:30:47.481Z", "endDate": "2020-10-09T15:30:00.000Z", "completeDate": "2020-10-09T16:33:43.453Z", "originBoardId": 114 }, { "id": 1208, "state": "closed", "name": "2020 Sprint 21", "startDate": "2020-10-12T16:34:00.000Z", "endDate": "2020-10-23T16:34:00.000Z", "completeDate": "2020-10-23T02:32:43.674Z", "originBoardId": 114 }, { "id": 1209, "state": "closed", "name": "2020 Sprint 22", "startDate": "2020-10-27T02:33:00.000Z", "endDate": "2020-11-07T02:33:00.000Z", "completeDate": "2020-11-06T17:45:42.610Z", "originBoardId": 114 }, { "id": 1210, "state": "closed", "name": "2020 Sprint 23", "startDate": "2020-11-09T17:49:00.000Z", "endDate": "2020-11-20T17:49:00.000Z", "completeDate": "2020-11-20T17:46:00.641Z", "originBoardId": 114 }, { "id": 1211, "state": "closed", "name": "2020 Sprint 24", "startDate": "2020-11-23T18:12:00.000Z", "endDate": "2020-12-07T18:12:00.000Z", "completeDate": "2020-12-04T22:07:24.313Z", "originBoardId": 114 }, { "id": 1212, "state": "closed", "name": "2020 Sprint 25", "startDate": "2020-12-07T22:11:00.000Z", "endDate": "2020-12-18T22:11:00.000Z", "completeDate": "2020-12-18T16:35:34.544Z", "originBoardId": 114 }, { "id": 1213, "state": "closed", "name": "2020 Sprint 26", "startDate": "2020-12-21T16:40:00.000Z", "endDate": "2021-01-08T16:40:00.000Z", "completeDate": "2021-01-08T17:37:31.799Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "455943", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "Note from customer testing the PR. As Chrome is hardcoded as the package name [here|https://github.com/appcelerator-modules/titanium-web-dialog/pull/19/files#diff-ec97b2a8e27b236611c64d3d1ac0a50bR91] the {{close}} event only works is Chrome is set as the default browser. Setting another browser (e.g. Samsung Browser or Edge) as the default causes the event to not be fired", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2020-06-26T10:24:10.000+0000", "updated": "2020-06-26T10:24:10.000+0000" }, { "id": "456183", "author": { "name": "aajain", "key": "aajain", "displayName": "Aakash Jain", "active": true, "timeZone": "America/Los_Angeles" }, "body": "The[PR#19|https://github.com/appcelerator-modules/titanium-web-dialog/pull/19]is fine per the code review. Also tested the close event functionality on sample application in this module. The close event is caught perfectly fine as required.\r\nHowever, if we call open method immediately after creating the object of the web-dialog module, then close event is not triggered for the first time. IMO, this scenario(calling open right after creating object) is very much possible hence this problem should be fixed as well. This would need some time to identify the best possible solutions for the same.\r\n[~ssingh]", "updateAuthor": { "name": "aajain", "key": "aajain", "displayName": "Aakash Jain", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-07-21T10:49:25.000+0000", "updated": "2020-07-21T10:49:45.000+0000" }, { "id": "456184", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "body": "As mentioned in: https://github.com/appcelerator-modules/titanium-web-dialog/pull/19#issuecomment-616761617\r\nIt needs a \"warm-up\" time (at least thats what they've called it in a stackoverflow ticket I think) to get ready. I'm not happy with the PR but I wasn't sure who to implement it correctly", "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2020-07-21T10:53:27.000+0000", "updated": "2020-07-21T10:53:27.000+0000" }, { "id": "456511", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "[~gmathews]/[~aajain] One further note from the customer on this, is there anything that we could possibly do to differentiate between the two, or would it have to be handled by the app code?\r\n\r\n{code}\r\nSo it looks like there is an issue with the pull request https://github.com/appcelerator-modules/titanium-web-dialog/pull/19 or, rather, googles implementation.\r\n\r\nThe close method is called upon TABS_HIDDEN (6) navigation event. The problem is that this is triggered for both a user closing and a deeplink close (pragmatically / user closed). So it looks like we may need to find a different means to detect just a user close.\r\n\r\nWhen I initially tested this it only appeared to get fired on a user close but that does not seem to be the case.\r\n\r\nUnfortunately, there is no other event that signifies a user close.\r\n{code}", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2020-08-19T09:49:01.000+0000", "updated": "2020-08-19T09:49:01.000+0000" }, { "id": "458011", "author": { "name": "aajain", "key": "aajain", "displayName": "Aakash Jain", "active": true, "timeZone": "America/Los_Angeles" }, "body": "The close event is being caught upon user close and deep-link close. Tested the same on the code: (https://gist.github.com/ewanharris/16909adfbfb43978858d5e7169d1bc9c ).\r\nHowever, debugged the code and found no information is there in close event callback that can help in distinguish between the two.\r\nAlso, looked into the CustomTabs apis which are being used but nothing useful for us in that.\r\n\r\n[~gmathews] can share incase he has any updates on the ticket.\r\n", "updateAuthor": { "name": "aajain", "key": "aajain", "displayName": "Aakash Jain", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2021-01-15T17:50:53.000+0000", "updated": "2021-01-15T17:50:53.000+0000" } ], "maxResults": 10, "total": 10, "startAt": 0 } } }