[TIMOB-10065] Android: TabGroup - Tab bar does not animate on Android
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2012-10-18T18:29:13.000+0000 |
Affected Version/s | Release 2.1.1, Release 3.0.0 |
Fix Version/s | Sprint 2012-15 Core, Release 2.1.1, Release 3.0.0, Release 3.1.0, 2012 Sprint 21 API, 2012 Sprint 21 |
Components | Android |
Labels | api, module_tabgroup, qe-and070112, qe-and100112, qe-testadded, regression |
Reporter | Tamila Smolich |
Assignee | Bill Dawson |
Created | 2012-07-20T14:58:40.000+0000 |
Updated | 2012-10-18T18:29:18.000+0000 |
Description
Description:
Tab bar does not animate and behavior of toggling between animating up/down is not shown.
This is regression. Does not occur on 2.1.0
Steps to reproduce:
1. Run the following code:
Titanium.UI.setBackgroundColor('#000');
// create tab group
var tabGroup = Titanium.UI.createTabGroup({bottom:-50});
//
// create base UI tab and root window
//
var win1 = Titanium.UI.createWindow({
title:'Tab 1',
backgroundColor:'#fff'
});
var tab1 = Titanium.UI.createTab({
icon:'KS_nav_views.png',
title:'Tab 1',
window:win1
});
var toggleBtn = Titanium.UI.createButton({
top:40,
height:35,
width:150,
title:'toggle tab bar'
});
win1.add(toggleBtn);
toggleBtn.addEventListener('click', function(e){
if (tabGroup.tabBarVisible == true) {
tabGroup.animate({bottom:-50,duration:500});
tabGroup.tabBarVisible = false;
} else {
tabGroup.animate({bottom:0,duration:500});
tabGroup.tabBarVisible = true;
}
});
//
// create controls tab and root window
//
var win2 = Titanium.UI.createWindow({
title:'Tab 2',
backgroundColor:'#fff'
});
var tab2 = Titanium.UI.createTab({
icon:'KS_nav_ui.png',
title:'Tab 2',
window:win2
});
var label2 = Titanium.UI.createLabel({
color:'#999',
text:'I am Window 2',
font:{fontSize:20,fontFamily:'Helvetica Neue'},
textAlign:'center',
width:'auto'
});
win2.add(label2);
//
// add tabs
//
tabGroup.addTab(tab1);
tabGroup.addTab(tab2);
// open tab group
tabGroup.open();
2. Press "toggle tab bar" several times
Expected result:
Tab bar should animate and behavior of toggling between animating up/down should work as expected
Actual result:
Tab bar does not animate
2_1_X Pull request ready: https://github.com/appcelerator/titanium_mobile/pull/2627
Tab bar animates. Verified on: Titanium Studio: 2.1.1.201207171343 Titanium SDK: 2.1.1.v20120723131610 Device: Android Samsung Tab GT-P6200 (v3.2)
Reopening issue. Tab bar does not animate on 3.0.0. Tested on: OS: Mac OS X Lion 10.7.4 Titanium Studio, build: 3.0.0.201210090117 Titanium SDK, build: 3.0.0.v20121009111437 Devices: Samsung Galaxy III (4.0.4), Nexus 7 (4.1.1) This is a regression, does not occur on 2.1.3.
Created [PR #3245](https://github.com/appcelerator/titanium_mobile/pull/3245) to resolve issue on master. This should also fix TIMOB-11393.
Master merge done. Ready for 3.0.X PR.
Created [PR #3251](https://github.com/appcelerator/titanium_mobile/pull/3251) to back port fix into 3_0_X.
3_0_X PR merged.
Closing as fixed. Verified and tested on: Titanium Studio, build: 3.0.0.201210151149 Titanium SDK, builds: 3.0.0.v20121017100120; 3.1.0.v20121017102121 Device: Nexus 7 (4.1.1)
Reopening to add estimates