Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-11442] CLI: titanium build should not allow --deploy-type to be set

GitHub Issuen/a
TypeBug
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2012-11-19T19:37:40.000+0000
Affected Version/sRelease 3.0.0
Fix Version/sRelease 3.0.0, 2012 Sprint 21 JS, 2012 Sprint 21
ComponentsTooling
Labelsqe-cli
ReporterNatalie Huynh
AssigneeChris Barber
Created2012-10-12T23:23:29.000+0000
Updated2012-12-04T23:03:43.000+0000

Description

Steps to Reproduce 1. Run "titanium build -h" Actual: Allows for user to set --deploy-type Expected: Deploy type is hard coded and Simulator = test Device = development Package = production If we allow use to modify this it will ruin all the analytics

Comments

  1. Chris Barber 2012-10-13

    This is new functionality. The old builder.py was indeed hard coded, however the correct settings were: * Simulator = "development" * Device = "test" * Package = "production" The --deploy-type for the new ios build command allows you to set the deploy type to "development" or "test" for only the simulator or device: * Simulator = --deploy-type value (either "development or "test") else "development" * Device = --deploy-type value (either "development or "test") else "test" * Package = "production"
  2. Chris Barber 2012-10-13

    Fixing this for Android build only.
  3. Chris Barber 2012-10-13

    Master pull request: https://github.com/appcelerator/titanium_mobile/pull/3209 3.0.x pull request: https://github.com/appcelerator/titanium_mobile/pull/3210
  4. Natalie Huynh 2012-10-18

    CLI 3.0.6 SDK 3.0.0.v20121017192538 Android deploy type is removed iOS deploy type still allows you to set device to test. We discussed that we are only allowing simulator to test or development.
  5. Chris Barber 2012-10-18

    We MUST allow the deploy type to be set for device. By default, device builds are set to "test" which will minify all JavaScript code. However when we debug on device, the line numbers are all messed up, so we must allow deploy type development for device.
  6. Natalie Huynh 2012-11-15

    If we allow this on iOS we need to allow the same for Android. Android currently does not allow you to set that
  7. Chris Barber 2012-11-19

    Marking as fixed because Android's build scripts today do not allow --deploy-type to be set, so there's no point to enable this.
  8. Natalie Huynh 2012-12-04

    Tested with CLI 3.0.19

JSON Source