[TIMOB-13170] Android: Implement javaShortArrayToJsNumberArray for proper short[] to v8 number array conversion
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Trivial |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2013-05-01T19:33:35.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | 2013 Sprint 09 Core, 2013 Sprint 09, Release 3.2.0 |
| Components | Android |
| Labels | andoid |
| Reporter | Max Stepanov |
| Assignee | Allen Yeung |
| Created | 2013-03-22T22:39:28.000+0000 |
| Updated | 2013-12-18T21:33:27.000+0000 |
Description
Should fix improper cast in
v8::Handle<v8::Array> TypeConverter::javaArrayToJsArray(JNIEnv *env, jshortArray javaShortArray)
{
return javaDoubleArrayToJsNumberArray(env, (jdoubleArray) javaShortArray);
}
Attachments
| File | Date | Size |
|---|---|---|
| com.typetest-android-0.1.zip | 2013-04-30T23:49:08.000+0000 | 45127 |
For testing, run the attached module to verify it does not crash. Please use the app.js in the example directory of the module.
PR: https://github.com/appcelerator/titanium_mobile/pull/4224
Verified the fix by running the attached module & used the app.js in the example folder inside the module. The module did not crash & ran successfully. Closing. Environment: Appcel Studio : 3.2.0.201312171913 Ti SDK : 3.2.0.v20131217190633 Mac OSX : 10.8.5 Alloy : 1.3.0-cr2 CLI - 3.2.0-cr3 Samsung Galaxy S4 running android 4.2.2