[TIMOB-13183] CodeProcessor: Merge require and common-globals plugins into ti-api-provider
GitHub Issue | n/a |
---|---|
Type | Story |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2013-08-22T00:42:32.000+0000 |
Affected Version/s | Release 3.0.0 |
Fix Version/s | 2013 Sprint 17, 2013 Sprint 17 Tooling, Release 3.2.0 |
Components | Code Processor |
Labels | n/a |
Reporter | Ingo Muschenetz |
Assignee | Matt Langston |
Created | 2013-03-24T22:47:35.000+0000 |
Updated | 2017-03-09T00:19:23.000+0000 |
Description
When we move to adding support for node.acs, there will be a clash with the existing require and common-globals. These plugins are really ti-specific, so they should go inside of the ti-api-provider plugin. This is also necessary to fix a current architectural issue preventing TIMOB-13088 from being implemented. Currently, the plugins directly set their variables/methods on the global object, but when they are integrated with ti-api-provider, they need to be updated to use the JSCA reading mechanisms in ti-api-provider
PR: https://github.com/appcelerator/titanium-code-processor/pull/231
To test: run the code analyzer on a Titanium app via 'ti analyze -p iphone --all-plugins' while using the latest (3.2.0) CLI (this will require a custom deployment of the CLI). This is a technical debt ticket, so if the PR works, there will be no change in the output.
Closing ticket as fixed.