[TIMOB-13970] Code Processor: Hack around the alloy hook never getting updated issue
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2013-05-24T20:20:43.000+0000 |
Affected Version/s | n/a |
Fix Version/s | 2013 Sprint 11 JS, 2013 Sprint 11, Release 3.1.1, Release 3.2.0 |
Components | Code Processor |
Labels | n/a |
Reporter | Bryan Hughes |
Assignee | Bryan Hughes |
Created | 2013-05-23T21:22:54.000+0000 |
Updated | 2013-05-29T01:35:37.000+0000 |
Description
The alloy hook never gets automatically updated, even when Alloy itself is updated. This means existing Alloy apps will not get the updated hook that the code processor requires, preventing the code processor from running in certain circumstances. Due to time constraints, this should be hacked around in the code processor.
PR: https://github.com/appcelerator/titanium-code-processor/pull/200 1_0_X PR: https://github.com/appcelerator/titanium-code-processor/pull/201
To test:
Take an Alloy project created with a version older than 1.1.3-alpha
Clean the project
"ti clean" from the command line
Run the code processor
"ti analyze -p iphone -A"
Without the fix, the alloy hook is not called and an error is displayed saying the project can't be analyzed (I forget the exact wording)
With the fix, the alloy hook is called (you can see its output) and the project is analyzed successfully
Code review and functional tests pass for both PR 200 and 201. Merged.
Verified as fixed using Code Processor 1.0.1-alpha3 and Alloy version 1.1.3-alpha (verified the wrong behavior is present if using Code Processor 1.0.1-alpha3 and Alloy version 1.1.2). Closing.