[TIMOB-14089] node-appc version delivered with SDK install is version 0.1.30, not 0.1.30-cr as in dependencies for code processor and CLI
| GitHub Issue | n/a |
|---|
| Type | Bug |
|---|
| Priority | Low |
|---|
| Status | Closed |
|---|
| Resolution | Invalid |
|---|
| Resolution Date | 2013-08-03T00:01:10.000+0000 |
|---|
| Affected Version/s | Release 3.1.1 |
|---|
| Fix Version/s | n/a |
|---|
| Components | Tooling |
|---|
| Labels | qe-3.1.1 |
|---|
| Reporter | Eric Merriman |
|---|
| Assignee | Chris Barber |
|---|
| Created | 2013-06-03T21:12:33.000+0000 |
|---|
| Updated | 2017-03-22T21:14:09.000+0000 |
|---|
Description
Description:
While testing the latest SDK and checking all the NPM packages, it was noted by Dustin that the node-appc version installed was 0.1.30 instead of 0.1.30-cr.
I am unsure if the version is identical, but this version should match the npm install versions.
Steps to reproduce:
1) Install build 3.1.1.v20130531163723 via your favorite method
2) Navigate to titanium/mobilesdk/osx/3.1.1.v20130531163723/node_modules/node-appc/package.json
3) Check the contents for the version
Result:
version is 0.1.30
Expected Result:
version is 0.1.30-cr
Comments
JSON Source
Wow, I never thought about that. The SDK isn't delivered as an NPM module, so our typical methods of messing with version numbers can't be used here. The only way I can think of off the top of my head is to commit the "-cr" prefix to the package.json in the repo and update the repo as we release new versions...that's really undesirable of course. Does anyone else have any ideas?
We discussed and this is currently not really a problem. We'll revisit this as part of 3.2.0
Right now, the node-appc that is bundled into the SDK is always the latest for a given branch (master, 3_1_X, etc), which coincidentally with the few changes to node-appc is identical to the RC version. To solve this problem, we need a number of things in place. First we need CI builds for node-appc. Then we need the SDK builder. The SDK CI build will invoke the new SDK builder which will need to identify the correct version of node-appc to bundle.
This is an old issue and we're moving on!
Closing ticket as invalid with reference to the above comments.