[TIMOB-14166] iOS: Delete section that include focused textfield causes app to crash
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2015-03-31T17:35:56.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 4.0.0 |
| Components | n/a |
| Labels | TSP, deleteSection, tableview, textfield |
| Reporter | Carter Lathrop |
| Assignee | Pedro Enrique |
| Created | 2013-06-10T09:00:31.000+0000 |
| Updated | 2015-04-09T21:08:08.000+0000 |
Description
If I want to delete section using "table.deleteSection(index, animate);" and I want to delete all sections application unfortunately crash. *Application crash only if I before clicked on a textfield ,so textfield has focus.
*EXAMPLE:*
var win = Ti.UI.createWindow({layout: "vertical"});
var table = Ti.UI.createTableView({ style: Ti.UI.iPhone.TableViewStyle.GROUPED });
var data = [];
var buttonsWrap = Ti.UI.createView({layout: "horizontal", width: Ti.UI.FILL, height: Ti.UI.SIZE});
var removeFromBottom = Ti.UI.createButton({title: "REMOVE FROM BOTTOM", width: "50%", height: 30});
removeFromTop = Ti.UI.createButton({title: "REMOVE FROM TOP", width: "50%", height: 30});
for(i=0;i<3;i++)
{
var section = Ti.UI.createTableViewSection({width: Ti.UI.FILL, height: Ti.UI.SIZE});
var row = Ti.UI.createTableViewRow({width: Ti.UI.FILL, height: Ti.UI.FILL, backgroundImage: "transparentBG.png"});
var tField = Ti.UI.createTextField({width: Ti.UI.FILL, height: Ti.UI.FILL, backgroundColor: "white"});
row.add(tField);
section.add(row);
data.push(section);
}
table.data = data;
buttonsWrap.add(removeFromBottom);
buttonsWrap.add(removeFromTop);
win.add(buttonsWrap);
win.add(table);
win.open();
removeFromBottom.addEventListener("click", function(){
table.deleteSection(2, {animationStyle: Ti.UI.iPhone.RowAnimationStyle.FADE});
table.deleteSection(1, {animationStyle: Ti.UI.iPhone.RowAnimationStyle.FADE});
table.deleteSection(0, {animationStyle: Ti.UI.iPhone.RowAnimationStyle.FADE});
});
removeFromTop.addEventListener("click", function(){
table.deleteSection(0, {animationStyle: Ti.UI.iPhone.RowAnimationStyle.FADE});
table.deleteSection(0, {animationStyle: Ti.UI.iPhone.RowAnimationStyle.FADE});
table.deleteSection(0, {animationStyle: Ti.UI.iPhone.RowAnimationStyle.FADE});
});
Confirmed with 3.2CI, iOS sim 6.0, with Titanium Studio, build: 3.1.0.201303032333. Thanks for bringing this to our attention. Moving to Ti-Mobile. Regards, Carter
[~egomez] confirming that there is a bug in TableView. The reason this is happening is that the TextFields have a height of "Ti.UI.SIZE" and the system is calculating a float value height of 49.6666 when you type something and then rounding that to 49.0. On editing the text by typing more, it goes back to 49.6666 and then it compares it to the previos 49.0. This tells the TableView to do an update on the rows, the sections, and so on. For some reason, still investigating, this is causing the internal TableView to fail a assert statement on the number or sections. To work around this, for now, hard code the height of the TextField to something appropriate, such as "44", or "50". Setting the height of the TextField will avoid all the automatic checks and unnecessary updates on the TableView data source. Solution: use a number for the height of the TextField instead of Ti.UI.SIZE
This issue is the same as the one related in TIMOB-17404 and is already fixed in 4_0_X and master branches
Verified the fix. Deleting the section that includes a focussed textfield does not crash the app. Closing. Environment: Appc Studio : 4.0.0.201504081125 Ti SDK : 4.0.0.v20150408131013 CLI : 4.0.0-beta5 Alloy : 1.6.0-beta2 MAC Yosemite : 10.10.2 Appc npm : 0.3.39 Appc CLI : 0.2.235